Closed Bug 1176462 Opened 4 years ago Closed 4 years ago

Remove nsTableDecoderSupport

Categories

(Core :: Internationalization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: emk, Assigned: emk)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No public decoders use nsTableDecoderSupport anymore. nsGB18030Unique2BytesToUnicode and nsGB18030Unique4BytesToUnicode are only remaining consumers. We can implement TryExtensionDecoder and Try4BytesDecoder by using nsUnicodeDecodeHelper::ConvertByTable directly. The full implementation of nsIUnicodeDecoder is unnecessary.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a299133b2a50
Attachment #8625028 - Flags: review?(smontagu)
Comment on attachment 8625028 [details] [diff] [review]
patch

Review of attachment 8625028 [details] [diff] [review]:
-----------------------------------------------------------------

Nice
Attachment #8625028 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/22ad2f837fda
Assignee: nobody → VYV03354
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.