Closed Bug 1176570 Opened 5 years ago Closed 5 years ago

Crash in mozilla::layers::DataTextureSourceD3D11::DataTextureSourceD3D11(mozilla::gfx::SurfaceFormat, mozilla::layers::CompositorD3D11*, ID3D11Texture2D*)

Categories

(Core :: Graphics: Layers, defect, critical)

Unspecified
Windows
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jesper, Assigned: mattwoodrow)

Details

(Keywords: crash, Whiteboard: [tbird crash])

Crash Data

Attachments

(1 file, 1 obsolete file)

Crashes: https://crash-stats.mozilla.com/report/list?product=Firefox&range_unit=days&range_value=28&signature=mozilla%3A%3Alayers%3A%3ADataTextureSourceD3D11%3A%3ADataTextureSourceD3D11%28mozilla%3A%3Agfx%3A%3ASurfaceFormat%2C+mozilla%3A%3Alayers%3A%3ACompositorD3D11*%2C+ID3D11Texture2D*%29#tab-reports

My crash: https://crash-stats.mozilla.com/report/index/cf6f8d90-2689-4a1f-9ea8-d69ab2150621

"youtube html5 playback crash at 14:59 after a reload of same html5 playback that stopped and reset to 0:00".

This is one of the odd crashes that appear to happen when using Firefox after restoring Windows from Standby/Hibernation.
Using an Nvidia 770gtx on desktop driver version: 352.86
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/d3d11/TextureD3D11.cpp#771 has mTextures[2] null, even though mTextures[0] is not null?
Flags: needinfo?(matt.woodrow)
That's plausible, if OpenSharedHandle failed for mTextures[2]. The second time we attempted lock then mTextures[0] would be non-null, so we wouldn't run OpenSharedHandle again.
Flags: needinfo?(matt.woodrow)
Attached patch open-shared-handle-crash (obsolete) — Splinter Review
I have no idea why OpenSharedHandle is failing for some of these though.
Assignee: nobody → matt.woodrow
Attachment #8625594 - Flags: review?(jmuizelaar)
Attachment #8625594 - Attachment is obsolete: true
Attachment #8625594 - Flags: review?(jmuizelaar)
Attachment #8625792 - Flags: review?(jmuizelaar)
Comment on attachment 8625792 [details] [diff] [review]
open-shared-handle-crash

Review of attachment 8625792 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok
Attachment #8625792 - Flags: review?(jmuizelaar) → review+
Crash Signature: [@ mozilla::layers::DataTextureSourceD3D11::DataTextureSourceD3D11(mozilla::gfx::SurfaceFormat, mozilla::layers::CompositorD3D11*, ID3D11Texture2D*) ]
Whiteboard: [tbird crash]
Keywords: crash
https://hg.mozilla.org/mozilla-central/rev/22bc3c641838
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.