create a clone of testCheck2.java that points to an autophone friendly url

RESOLVED FIXED in Firefox 42

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
currently tcheck2 is hardcoded to find files at startup_test/fennecmark/cnn/cnn.com/index.html:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/tests/browser/robocop/testCheck2.java#16

in order to get this on autophone we need to have that path, or use a path which exists (in files/ep1/cnn/cnn.com/index.html).  I believe having a clone of the test which points to the ep1 version will allow us to get up and running and when we stop running on talos we can remove testCheck2.java.
(Assignee)

Comment 1

3 years ago
Created attachment 8625142 [details] [diff] [review]
tcheck3 ftw (1.0)

:bc, this is a simple copy of tcheck2 with the url changed to fine the test page.  Can you verify that this looks like the right url:
%(webserver)s/cnn/cnn.com/index.html

This should work with your existing phone dash, alternatively we could pass in additional arguments to tcheck3 if you prefer.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8625142 - Flags: review?(bob)

Comment 2

3 years ago
Comment on attachment 8625142 [details] [diff] [review]
tcheck3 ftw (1.0)

Review of attachment 8625142 [details] [diff] [review]:
-----------------------------------------------------------------

sorry for the delay. After understanding the getAbsoluteUrl stuff, I essentially compared to testCheck2.java
Attachment #8625142 - Flags: review?(bob) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8632731 [details] [diff] [review]
tcheck3 with facebook.com (1.1)

same as the last patch, but this time we have changed the url from the old cnn.com to the updated facebook.com page.
Attachment #8625142 - Attachment is obsolete: true
Attachment #8632731 - Flags: review?(bob)

Updated

3 years ago
Attachment #8632731 - Flags: review?(bob) → review+
(Assignee)

Comment 4

3 years ago
thanks bc, i will get this in for nightly!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2f28e9e0009a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.