1176583 - figure out preferences for tcheck2 in order to run successfully

Status: RESOLVED DUPLICATE of bug 1172108

(Testing Graveyard :: Autophone, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I believe these are the additional preferences we need:
'talos.logfile': '%s/browser_output.txt' % self._paths['dest'],
'media.gmp-manager.url': 'http://127.0.0.1/gmpmanager-dummy/update.xml',
'extensions.update.background.url': 'http://127.0.0.1/extensions-dummy/updateBackgroundURL',

* talos.logfile is needed for the test itself
* media.gmp-manager.url - we attempt to access outside resources, this stops that
* extensions.update.background.url - we attempt to access outside resources, this stops that

I am not sure if these are used in other parts of the code, or if something specific about tcheck2 is triggering parts of the browser.  Ideally these should be in all tests.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:bc, do you have thoughts on these specific preferences?

Comment 2

[Bob Clary [:bc] (inactive)]

(In reply to Joel Maher (:jmaher) from comment #0)
> I believe these are the additional preferences we need:
> 'talos.logfile': '%s/browser_output.txt' % self._paths['dest'],

I wouldn't put it in the dest directory. I'd put it in under the test root where the other output it placed.

> 'media.gmp-manager.url': 'http://127.0.0.1/gmpmanager-dummy/update.xml',
> 'extensions.update.background.url':
> 'http://127.0.0.1/extensions-dummy/updateBackgroundURL',

            'extensions.update.enabled': False,

isn't sufficient? We can definitely add this if we need it.

> 
> * talos.logfile is needed for the test itself
> * media.gmp-manager.url - we attempt to access outside resources, this stops
> that
> * extensions.update.background.url - we attempt to access outside resources,
> this stops that
> 
> I am not sure if these are used in other parts of the code, or if something
> specific about tcheck2 is triggering parts of the browser.  Ideally these
> should be in all tests.

Seems reasonable. I have a plan for revamping the way autophone sets browser preferences and how they can be better customized per test. I can work it out this coming week and we can go from there.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for the info, I can get the logfile in the right spot.

As for extensions.update.enabled, it failed for me while running it locally.  of course I could have done something wrong, but adding those two preferences allowed me to see some results in adb logcat.

sounds like we can make this work without a lot of pain.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

ok, I am not clear where the test root is- any pointers, maybe an example from s1s2test.py?

Comment 5

[Bob Clary [:bc] (inactive)]

Lets hook up in garabaldi this pm.

Comment 6

[Bob Clary [:bc] (inactive)]

(In reply to Joel Maher (:jmaher) from comment #4)
> ok, I am not clear where the test root is- any pointers, maybe an example
> from s1s2test.py?

This is set in adb.py's def test_root:
https://github.com/mozilla/autophone/blob/master/adb.py#L685

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

it sounds like I should just have the one preference of talos.logfile defined and the rest can be defaults for autophone.  Let me revisit the need for talos.logfile whilst I am working on this :)

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

these are in and will be resolved in bug 1172108.