Closed Bug 1176677 Opened 9 years ago Closed 9 years ago

[moznetwork] ImportError: "cannot import name structured", and release version 0.26

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 affected, firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

mozlog v1.1
1.24 KB, patch
whimboo
: review+
Details | Diff | Splinter Review 
Bug 1160090 added mozlog.structured support to moznetwork, but missed to add the dependency to the setup.py file. That means tools which use moznetwork via pypi are broken right now because the dependency is not getting installed.
Dave, can you get this fixed please? Thanks
Flags: needinfo?(dave.hunt)
Sorry about this. I'm traveling today so unable to prepare a patch but it should be trivial and I'd be able to review a patch. If I understand correctly this shouldn't cause issues so long as you pin your dependencies, or if you are using recent mozlog package.
Flags: needinfo?(dave.hunt)
I have a minute now to get this fixed. I will prepare a patch which will also release a new version of mozlog.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Summary: [moznetwork] ImportError: cannot import name structured → [moznetwork] ImportError: "cannot import name structured", and release version 2.12
Summary: [moznetwork] ImportError: "cannot import name structured", and release version 2.12 → [moznetwork] ImportError: "cannot import name structured", and release version 0.26
Attached patch mozlog (obsolete) — — Splinter Review 
Just a dep update and version bump. I don't think we have to stress try for that.
Attachment #8625471 - Flags: review?(dave.hunt)
Comment on attachment 8625471 [details] [diff] [review]
mozlog

Review of attachment 8625471 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with or without the comment addressed

::: testing/mozbase/moznetwork/setup.py
@@ +8,3 @@
>  
> +deps = ['mozinfo',
> +        'mozlog',

We use structured logging, so I think we should specify a minumum version. Perhaps the current released version?
Attachment #8625471 - Flags: review?(dave.hunt) → review+
Attached patch mozlog v1.1 — — Splinter Review 
That makes total sense! Thanks Dave. I set the current version as minimum.
Attachment #8625471 - Attachment is obsolete: true
Attachment #8625669 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/cc01fa41cf9a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Released to PyPI:

Submitting dist/moznetwork-0.26.tar.gz to https://pypi.python.org/pypi
Server response (200): OK
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: