Closed
Bug 1176730
Opened 9 years ago
Closed 9 years ago
Don't use pthread for libvpx in mingw builds.
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox39 | --- | unaffected |
firefox40 | --- | fixed |
firefox41 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file, 1 obsolete file)
3.54 KB,
patch
|
rillian
:
review+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
mingw can optionally have pthread support, but even if it does, it doesn't make sense to use it on Windows when support for native Windows threading is provided anyway. Currently, mingw build without pthread fails.
Attachment #8625317 -
Flags: review?(j)
Comment 1•9 years ago
|
||
Comment on attachment 8625317 [details] [diff] [review] patch Review of attachment 8625317 [details] [diff] [review]: ----------------------------------------------------------------- Patch looks ok but needs to be added to update.py so its not lost with the next update.
Attachment #8625317 -
Flags: review?(j) → review-
Comment 2•9 years ago
|
||
Attachment #8625317 -
Attachment is obsolete: true
Attachment #8625425 -
Flags: review?(giles)
Comment 3•9 years ago
|
||
Comment on attachment 8625425 [details] [diff] [review] 0001-Bug-1176730-Don-t-use-pthread-for-libvpx-in-mingw-bu.patch Review of attachment 8625425 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/libvpx/vpx_config_x86-win32-gcc.h @@ +35,4 @@ > #define HAVE_VPX_PORTS 1 > #define HAVE_STDINT_H 1 > #define HAVE_ALT_TREE_LAYOUT 0 > +#undef HAVE_PTHREAD_H Why is the undef necessary?
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Ralph Giles (:rillian) from comment #3) > Comment on attachment 8625425 [details] [diff] [review] > 0001-Bug-1176730-Don-t-use-pthread-for-libvpx-in-mingw-bu.patch > > Review of attachment 8625425 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: media/libvpx/vpx_config_x86-win32-gcc.h > @@ +35,4 @@ > > #define HAVE_VPX_PORTS 1 > > #define HAVE_STDINT_H 1 > > #define HAVE_ALT_TREE_LAYOUT 0 > > +#undef HAVE_PTHREAD_H > > Why is the undef necessary? We have a check for pthread.h in configure script. If it's found then HAVE_PTHREAD_H is defined in mozilla-config.h and we have a warning here.
Comment 5•9 years ago
|
||
Comment on attachment 8625425 [details] [diff] [review] 0001-Bug-1176730-Don-t-use-pthread-for-libvpx-in-mingw-bu.patch Ok, looks fine to me.
Attachment #8625425 -
Flags: review?(giles) → review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/30f68d9c65a5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment 8•9 years ago
|
||
Comment on attachment 8625425 [details] [diff] [review] 0001-Bug-1176730-Don-t-use-pthread-for-libvpx-in-mingw-bu.patch Approval Request Comment [Feature/regressing bug #]: Bug 1151175 [User impact if declined]: This is needed for uplift of newer libvpx changes. [Describe test coverage new/current, TreeHerder]: Landed on m-c some time ago. [Risks and why]: Risk is minimal. This doesn't affect officially supported builds. [String/UUID change made/needed]: None.
Attachment #8625425 -
Flags: approval-mozilla-beta?
Updated•9 years ago
|
Blocks: 1178215
status-firefox39:
--- → unaffected
status-firefox40:
--- → affected
Flags: needinfo?(abillings)
Comment 9•9 years ago
|
||
Comment on attachment 8625425 [details] [diff] [review] 0001-Bug-1176730-Don-t-use-pthread-for-libvpx-in-mingw-bu.patch As Ralph stated, this is a no-op for officially supported builds. Beta+
Attachment #8625425 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/b92f62aa6643 (In reply to Al Billings [:abillings] from comment #10) > Don't we need this on Aurora as well? This landed prior to the uplift.
You need to log in
before you can comment on or make changes to this bug.
Description
•