1176735 - xpcshell tests forkbomb locally and die

Status: RESOLVED WORKSFORME

(Testing :: XPCShell Harness, defect)

Description

[Steve Fink [:sfink] [:s:]]

I am never able to run the xpcshell tests locally. When I do

  ./mach test xpcshell

a few tests run ("Thread-75" is the highest I see in the current output), but then everything crashes down and fails with the error

  error: can't start new thread

If I force the tests to run sequentially with the patch below, then it runs to completion. Seems like there should be a concurrency limit or something?

diff --git a/testing/xpcshell/mach_commands.py b/testing/xpcshell/mach_commands.py
--- a/testing/xpcshell/mach_commands.py
+++ b/testing/xpcshell/mach_commands.py
@@ -58,17 +58,17 @@ class XPCShellRunner(MozbuildObject):
     def run_test(self, test_paths, interactive=False,
-                 keep_going=False, sequential=False, shuffle=False,
+                 keep_going=False, sequential=True, shuffle=False,
                  debugger=None, debuggerArgs=None, debuggerInteractive=None,
                  jsDebugger=False, jsDebuggerPort=None,

Comment 1

[Chris Manchester (limited bugmail, email directly)]

This works alright for me locally... we're intending to set the maximum number of threads to cpu count * 4, maybe that's too high in some circumstances.

You should be able to pass --sequential to mach to get them to run sequentially without patching the command.

Comment 2

[Steve Fink [:sfink] [:s:]]

(In reply to Chris Manchester [:chmanchester] from comment #1)
> This works alright for me locally... we're intending to set the maximum
> number of threads to cpu count * 4, maybe that's too high in some
> circumstances.

Hm. That should be 32 for me. That doesn't seem very high. Maybe I'll look into that once I have a build again.

> You should be able to pass --sequential to mach to get them to run
> sequentially without patching the command.

Yeah, thanks, I noticed that when I undid my local patch. Much easier!

Comment 3

[Geoff Brown [:gbrown]]

I haven't heard of others having this problem, and I cannot reproduce. Please re-open if this is still an issue.