1176751 - Check for native conversions needed when optimizing element accesses

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

Unboxed plain objects are converted to native objects during Ion compilation when used during property accesses, but no corresponding operation is performed for accesses on unboxed array elements.  This hurts performance on octane-navier-stokes as we use inline caches instead of dense accesses on converted native at some access sites.  The attached patch adds these conversions and cleans up the process for adding them somewhat.

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 8625334 [details] [diff] [review]
patch

Review of attachment 8625334 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1398d03aed65

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1398d03aed65