Closed
Bug 1176751
Opened 9 years ago
Closed 9 years ago
Check for native conversions needed when optimizing element accesses
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla42
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
25.39 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Unboxed plain objects are converted to native objects during Ion compilation when used during property accesses, but no corresponding operation is performed for accesses on unboxed array elements. This hurts performance on octane-navier-stokes as we use inline caches instead of dense accesses on converted native at some access sites. The attached patch adds these conversions and cleans up the process for adding them somewhat.
Attachment #8625334 -
Flags: review?(jdemooij)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8625334 [details] [diff] [review]
patch
Review of attachment 8625334 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the delay.
Attachment #8625334 -
Flags: review?(jdemooij) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•