Closed Bug 1176778 Opened 5 years ago Closed 5 years ago

Enable jsx-sort-props eslint rule

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
2

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Iteration:
41.3 - Jun 29
Tracking Status
firefox41 --- fixed
Blocking Flags:
backlog tech-debt

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

Sorting the props when creating components enables easier visual comparison with better scanning.
Flags: qe-verify-
Flags: firefox-backlog+
This is all manual re-ordering. The unit tests picked out the one case where I got it wrong.

Don't mind who reviews this, but it'd be nice to land it soonish.
Attachment #8625379 - Flags: review?(mdeboer)
Attachment #8625379 - Flags: review?(dmose)
Blocks: 1176780
Comment on attachment 8625379 [details] [diff] [review]
Enable jsx-sort-props eslint rule for Loop.

Review of attachment 8625379 [details] [diff] [review]:
-----------------------------------------------------------------

rs=dmose
Attachment #8625379 - Flags: review?(mdeboer)
Attachment #8625379 - Flags: review?(dmose)
Attachment #8625379 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/2b391a831518
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.