Closed Bug 1176860 Opened 9 years ago Closed 6 years ago

Menu-button labels with toolbarbutton-1 don't highlight on highlight when placed on the nav-bar

Categories

(Firefox :: Theme, defect)

All
Windows
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mkaply, Unassigned)

Details

Attachments

(2 files)

If you make the label visible for a toolbarbutton-1 menu-button that is on the nav-bar, the label doesn't highlight. The image and dropdown highlight around it.

buttons and menu buttons do highlight (not perfectly, but at least they highlight).

This works properly on Mac.

I know someone will say "There shouldn't be labels on the nav-bar", but there might be cases where add-ons do this and it should work properly without the add-on having to do custom highlighting.
We have no way of knowing you made the label visible, so we can't style it for you. If you use styling to make it visible, you also get to add CSS styling to make the hover/focus styles work. That it "works" on mac is an implementation detail regarding how we style icons on Windows/Linux (specifically in order to get the click areas appropriately sized).
Status: NEW → RESOLVED
Closed: 9 years ago
Component: Toolbars and Customization → Theme
Resolution: --- → WONTFIX
The label highlights "fine" on buttons and menu buttons, so this was just an oversight on menu-buttons.

I shouldn't have to implement custom highlighting on Windows only.
Attached patch Fix for problemSplinter Review
Here's the fix for the problem.

The issue was that when these new rules were created, the menu-buttons toolbarbutton-text was left out.

This at least makes them highlight. Not perfect, but at least works as well as the other buttons when the text is shown.
So I will go ahead and say that I was wrong in my initial resolution. So I'm going to reopen this. Sorry.

Regarding the patch, this looks like it goes in the right direction but you missed the pre-win8 versions of the selectors and the :active styles.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
I'll update the patch.

The active styles are interesting. I was originally going to file a separate bug because the button in a menu-button doesn't handle :active correctly.

I'll take care of it in this patch.

And no apology necessary. I'm sorry if I've come on to strong in these bugs.
So the active problem is strange. What I've discovered is that the toolbarbutton-icon in the menu-button only is not getting any of its colors from  --toolbarbutton-hover-background or  --toolbarbutton-active-background.

If I change those two values in the CSS, all the other buttons get the change (including my new change for the menu-button-text), but not the menu-button-icon.

So somewhere, someone else is setting the highlight and active for the menu-button and the CSS is such that browser.css is not overriding it.
It was this change:

http://mxr.mozilla.org/mozilla-esr38/source/browser/themes/windows/browser-aero.css#316

That was bookmarks specific but not set so with CSS.

This code was heavily modified recently, so I'll have to find it in the new versions.
That code was just removed in bug 1178004.
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> That code was just removed in bug 1178004.

Hurrah.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → DUPLICATE
There are still bugs here. Just that one issue isn't there.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: REOPENED → RESOLVED
Closed: 9 years ago6 years ago
Resolution: --- → INACTIVE
Pretty sure we got rid of these.
Resolution: INACTIVE → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: