Closed Bug 1176890 Opened 5 years ago Closed 5 years ago

Start jstests faster on Windows

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: terrence, Assigned: terrence)

Details

Attachments

(1 file)

On windows I/O and process startup is *slow*. On linux, scanning the tests and evaluating the headers takes ~1-2s: annoying but livable. On windows it takes 5-10s: actively infuriating.
Attachment #8625494 - Flags: review?(sphink)
Attachment #8625494 - Attachment is patch: true
Attachment #8625494 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 8625494 [details] [diff] [review]
run_tests_instantly_in_windows-v0.diff

Review of attachment 8625494 [details] [diff] [review]:
-----------------------------------------------------------------

Generator all the things!

::: js/src/tests/lib/manifest.py
@@ +333,5 @@
> +                    'js-test-driver-begin.js', 'js-test-driver-end.js'))
> +
> +    # Skip js files in the root test directory.
> +    if not root:
> +        return False

This reads backwards. "If this isn't a root, return False".

Maybe s/root/path_from_root/ ?

@@ +349,5 @@
> +    if filename in excluded_paths:
> +        return False
> +
> +    return True
> +    

Extra line. With whitespace, even.
Attachment #8625494 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/198da127cf26
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.