1176895 - [spark] Task switcher / Tab switcher not always centered on current window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Task Manager, defect)

Description

[Dan Callahan [:callahad]]

STR:

1. Open a bunch of tabs
2. Menu -> Show Windows

What should happen:

- The tab switcher appears, with my current page focused.

What actually happens:

- The tab switcher appears, but often (not always!) focuses the most recently opened page, instead of the page I'm looking at.

The inconsistency makes it impossible to develop muscle memory for closing tabs.

The lack of undo (Bug 1176894) means that I regularly (3+ times a week) end up losing tabs to accidental closing

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

QAWANTED: I think this is a duplicate bug.  Could you investigate which bug it's a dup of?

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

I cannot reproduce this bug on Aries. I had over 10 websites opened, and each time I tap on ellipsis icon > Show Window, it always shows my current window. Bug repro rate: 0 out of ~25.

On Flame it constantly LMK's due to low memory. See bug 1172167.

Reporter could you provide a more detailed STR? A video demonstrating the bug would be helpful.

Leaving QAWanted tag for others to attempt.

Device: Aries (RC4 > OTA'ed)
BuildID: 20150701171852
Gaia: 26b853b7cf94ea9e9ac6f20c55db462bd213a959
Gecko: ca0fd580a9ce
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 3

[Dan Callahan [:callahad]]

I don't have consistent STRs, but once it occurs, I tend to get it several times in a row.

I'll try to capture a video the next time it happens.

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I was not able to reproduce this issue on the latest Aries spark build.

Actual Results: The task switcher was correctly centered.

Environmental Variables:
Device: Aries 2.5
BuildID: 20150731163020
Gaia: 8502d07cd7e68da79303471acf64eea48b3dce24
Gecko: ca53d4297f02
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 5

[Duane Dixon [:ddixon]]

I was able to reproduce this issue.  It seems to reproduce, as Comment 3 describes, in consecutive groupings.  I used an Aries device and a Flame device in light of bug 1172167 (Comment 2).  

Repro Steps: 
1. Open 8-10 separate windows in Browser app. 
2. Once 8-10 tabs are open, side gesture (left or right) to another window
3. Allow each window to load before the next swipe
4. At the final window, select "..." then "Show windows"

NOTE: When side gesturing left or right, start from one side and go all the way to the oldest/newest window as the video illustrates. 

Actual Result: 
The user is taken to the incorrect browser window after side swiping to older windows then selecting "Show windows" in Browser app.  

Repro frequency: About 5/25

Video: http://youtu.be/UUuMGt4hXNE
  
Environmental Variables:
Device: Aries 2.5
Build ID: 20150902124951
Gaia: e2fab8f6ac345ecde10a1350e699be9ceb6987d6
Gecko: 1b687fcb5213153855c7ac0f8392ce0a4a7e3382
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

I did not find a duplicate of this bug (comment 1)...

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Let's get branch checks of this issue using the steps from comment 5.

Comment 7

[Duane Dixon [:ddixon]]

Branch Check 

Issue DOES occur in Flame 2.5 (512 MB memory, a maximum of 4 windows can be opened at a time).  

Repro Attempts: 4/5

Device: Flame 2.5
Build ID: 20150902045425
Gaia: e2fab8f6ac345ecde10a1350e699be9ceb6987d6
Gecko: 1b687fcb5213153855c7ac0f8392ce0a4a7e3382
Version: 43.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
-----------------------------------------------------
Issue DOES NOT occur in Flame 2.2 (512 MB memory). 

Repro Attempts: 0/15 

Device: Flame 2.2
BuildID: 20150901092824
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: c03e2bc6a3a4
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 8

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Let's get a regression window on this then.

Comment 9

[Duane Dixon [:ddixon]]

B2G Inbound Regression Window

Last Working 

Device: Flame 2.5
BuildID: 20150612172044
Gaia: 6c41f358c0174bc6702df979232824459ccc2f41
Gecko: aa109a7d3c9a
Version: 41.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken 

Device: Flame 2.5
BuildID: 20150612174339
Gaia: 1bf2da102560481748ff3f6202fbed5c4daa5832
Gecko: 918f5d2e3e5f
Version: 41.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: 6c41f358c0174bc6702df979232824459ccc2f41
Gecko: 918f5d2e3e5f

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 1bf2da102560481748ff3f6202fbed5c4daa5832
Gecko: aa109a7d3c9a

B2G Inbound Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/6c41f358c0174bc6702df979232824459ccc2f41...1bf2da102560481748ff3f6202fbed5c4daa5832

Possible Cause: 

Bug 1161229 - Use CSS Scroll Snapping in card view.

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Sam this issue seems to have been caused by the changes for bug 1161229.  Can you please take a look?

Comment 11

[Sam Foster [:sfoster] (he/him)]

(In reply to Jayme Mercado [:JMercado] from comment #10)
> Sam this issue seems to have been caused by the changes for bug 1161229. 
> Can you please take a look?

Ok yeah I see what's going on - I was confused at first. So the STR for this should be: 

1. Open multiple browser or app windows
2. Holdhome to show task manager
3. Select any but the first card in the task manager to open that app/window
4. Use edge swipe to go back to the first app you opened
5. Holdhome to show the task manager again

Expect result: The first app's in the task switcher card should be centered in the viewport
Actual result: The app selected from step 3 is centered. 

I see what's going on here, I get a patch in.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:task-manager-centering-bug-1176895 > mozilla-b2g:master

Comment 13

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8657294 [details] [review]
[gaia] sfoster:task-manager-centering-bug-1176895 > mozilla-b2g:master

Fixes a logic error - as we dont reset scrollLeft (and shouldnt rely on that) by only centering when stackIndex (StackManager position) was > 0, we could end up with the wrong app centered. Added a unit test for this case.

Comment 14

[Etienne Segonzac (:etienne)]

Comment on attachment 8657294 [details] [review]
[gaia] sfoster:task-manager-centering-bug-1176895 > mozilla-b2g:master

:+1:

r=me with nits

Comment 15

[Sam Foster [:sfoster] (he/him)]

I broke out those tests as suggested, on master: 
https://github.com/mozilla-b2g/gaia/commit/70b68a1776e273e9c06f66cae6f85d09460271f8