Closed Bug 1176901 Opened 9 years ago Closed 9 years ago

[music] Support "data length indicator" in ID3v2

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: squib, Assigned: squib)

Details

Attachments

(1 file)

Fix it
46 bytes, text/x-github-pull-request
djf
: review+
Details | Review 
I'll write more later but I have a patch for this. Blah blah.
Attached file Fix it — 
This patch adds support for the "data length indicator" in ID3v2.4. I found that one of my albums uses this flag, and so I had a good test case. I've also added unit tests, of course.
Attachment #8625631 - Flags: review?(dflanagan)
Comment on attachment 8625631 [details] [review]
Fix it

A couple of minor things on github, but otherwise this looks good to me.
Attachment #8625631 - Flags: review?(dflanagan) → review+
Landed with review comments addressed: https://github.com/mozilla-b2g/gaia/commit/a2c1e76319ee33ab85612448371cff8786799a63
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: