Closed Bug 1176905 Opened 7 years ago Closed 7 years ago

[FTU] Convert checkboxes to use gaia-checkbox

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S1 (26Jun)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

[Pull Request] Convert FTU checkboxes to gaia-checkbox
46 bytes, text/x-github-pull-request
sfoster
: review+
Details | Review 
In preparation of moving away from building blocks, and onto web components.
Comment on attachment 8625507 [details] [review]
[Pull Request] Convert FTU checkboxes to gaia-checkbox

Hey Sam - could you take a look at this whenever you get a chance? Thanks!
Attachment #8625507 - Flags: review?(sfoster)
Comment on attachment 8625507 [details] [review]
[Pull Request] Convert FTU checkboxes to gaia-checkbox

Looks great, thanks. There doesnt seem to be any value in changing the checkbox in mock_navigation_index.html - that is just there to test disabled state - so this looks good to go.
Attachment #8625507 - Flags: review?(sfoster) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/a1b180b1964dfd939798d7e076435f421fca983f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1179267
Target Milestone: --- → FxOS-S1 (26Jun)
You need to log in before you can comment on or make changes to this bug.