1176933 - Enable jsx prop types rule for eslint (ensure prop types are specified for used props)

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

We should enable the prop types rule for eslint, as this will ensure all our props are listed in the component definition.

Comment 1

[Mark Banner (:standard8)]

Attachment: Enable missing props validation elint rule checking for Loop.

Relies on the patch chain for bug 1176780.

Comment 2

[Mark Banner (:standard8)]

Attachment: Enable missing props validation elint rule checking for Loop.

Complete patch

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8625525 [details] [diff] [review]
Enable missing props validation elint rule checking for Loop.

Review of attachment 8625525 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose, with any appropriate comments addressed.

::: browser/components/loop/content/js/contacts.jsx
@@ +337,5 @@
>      propTypes: {
>        notifications: React.PropTypes.instanceOf(
> +        loop.shared.models.NotificationCollection).isRequired,
> +      // Callback to handle entry to the add/edit contact form.
> +      startForm: React.PropTypes.func.isRequired

Indentation error.

@@ +628,5 @@
>      mixins: [React.addons.LinkedStateMixin],
>  
>      propTypes: {
> +      mode: React.PropTypes.string,
> +      selectTab: React.PropTypes.func.isRequired

Add a comment describing what this means?

::: browser/components/loop/content/js/panel.jsx
@@ +19,5 @@
>  
>    var TabView = React.createClass({
>      propTypes: {
>        buttonsHidden: React.PropTypes.array,
> +      children: React.PropTypes.element,

Should this be isRequired?

::: browser/components/loop/content/shared/js/feedbackViews.jsx
@@ +22,5 @@
>     * -
>     */
>    var FeedbackLayout = React.createClass({
>      propTypes: {
> +      children: React.PropTypes.element,

Why no longer required?

Comment 4

[Mark Banner (:standard8)]

(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #3)
> ::: browser/components/loop/content/shared/js/feedbackViews.jsx
> @@ +22,5 @@
> >    var FeedbackLayout = React.createClass({
> >      propTypes: {
> > +      children: React.PropTypes.element,
> 
> Why no longer required?

FeedbackReceived#render doesn't always return elements for standalone, and hence this throws a warning.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fa660238a158

Comment 6

[Guilherme Lima]

Didn't got marked when landed - https://hg.mozilla.org/mozilla-central/rev/fa660238a158