New MSE doesn't handle changing encryption keys.

RESOLVED FIXED in Firefox 41

Status

()

Product:
Core
Component:
Audio/Video
Type:
defect
Status:
RESOLVED FIXED
Opened:
4 years ago
Updated:
4 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

Version:
Trunk
Target:
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

Inform MediaSourceDecoder about new encryption keys inside TrackBuffersManager.
4.42 KB, patch
cpearce
: review+
Details | Diff | Splinter Review 
The MediaFormatReader handles EME keys during the ReadMetadata() ; however, with MSE multiple init segment may be found in the TrackBuffer.

We need to handle all keys for each init segment and fire the associated encrypted event.
Assignee: nobody → jyavenard
Summary: New MSE doesn't handle changing encryption key. → New MSE doesn't handle changing encryption keys.
Comment on attachment 8625586 [details] [diff] [review]
Inform MediaSourceDecoder about new encryption keys inside TrackBuffersManager.

Review of attachment 8625586 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/mediasource/TrackBuffersManager.cpp
@@ +1016,5 @@
>      }
>  #endif // MOZ_EME
>      info.mCrypto = *crypto;
> +    // We clear our crypto init data array, so the MediaFormatReader will
> +    // not emit the encrypted event again.

// not emit an encrypted event for the same init data again.
Attachment #8625586 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/4cc713d3e7c0
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.