Closed Bug 1177023 Opened 9 years ago Closed 9 years ago

Log isRootContent when dumping FrameMetrics

Categories

(Core :: Graphics: Layers, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Attached patch PAtchSplinter Review
We're not dumping the is-root-content flag when dumping FrameMetrics, and it's kinda useful to have now.
Attachment #8625648 - Flags: review?(botond)
Comment on attachment 8625648 [details] [diff] [review]
PAtch

Review of attachment 8625648 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/LayersLogging.cpp
@@ +204,5 @@
>      aStream << nsPrintfCString(")] [u=(%d %d %lu)",
>              m.GetScrollOffsetUpdated(), m.GetDoSmoothScroll(),
>              m.GetScrollGeneration()).get();
>      AppendToString(aStream, m.GetScrollParentId(), "] [p=");
> +    aStream << nsPrintfCString("] [i=(%ld %lld %d)] }",

Wouldn't it be more readable to put [rcd] here too? Or is your intention to conserve space?
Attachment #8625648 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/5d00f1dba2d2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: