Compiler errors in GTK3 build with clang

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: botond, Assigned: botond)

Tracking

unspecified
mozilla41
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
I did a GTK3 build of trunk with clang as the compiler, and got some warnings-as-errors. Will post a patch that fixes them.
(Assignee)

Comment 1

4 years ago
Created attachment 8625650 [details]
MozReview Request: Bug 1177024 - Fix clang warnings-as-errors in GTK3 build. r=karlt

Bug 1177024 - Fix clang warnings-as-errors in GTK3 build. r=karlt
Attachment #8625650 - Flags: review?(karlt)
(Assignee)

Updated

4 years ago
Assignee: nobody → botond
Comment on attachment 8625650 [details]
MozReview Request: Bug 1177024 - Fix clang warnings-as-errors in GTK3 build. r=karlt

https://reviewboard.mozilla.org/r/11901/#review10433

Ship It!

::: widget/gtk/nsWindow.cpp:1950
(Diff revision 1)
>  #else
>      haveEvent = false;

Please remove this now unnecessary #else block.
Attachment #8625650 - Flags: review?(karlt) → review+
(Assignee)

Comment 3

4 years ago
Thanks! Addressed comment and landed.
https://hg.mozilla.org/mozilla-central/rev/46b5faf58c7b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.