1177025 - (SM2.35) Tracking bug for build and release of SeaMonkey 2.35

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect, P1)

Description

[Philip Chee]

This is a tracking bug for Build and Release of SeaMonkey 2.35

We expect an actual release before the end of June.

Comment 1

[Edmund Wong (:ewong)]

Not sure where to put this note, but the patch for bug 1177634 has
to be uplifted to mozilla-esr38.

Comment 2

[erpman1]

Octember 2015?  I think you mis-spelled this.  It should be "October" 2015.

Comment 3

[rsx11m]

But it's at the location of Julgust, thus needs to be corrected either way.

Comment 4

[erpman1]

you mean "August", rsx11m?  ask ewong and see if he can get the information here corrected.  we really don't want to confuse the Seamonkey users about the upcoming SM 2.35 release.

Comment 5

[rsx11m]

No, I meant it in the same way as Ratty meant to say "Octember" as listed above.  ;-)
I'd have to read Dr. Seuss, but I don't think it's between July and August...

Comment 6

[Edmund Wong (:ewong)]

Attachment: update Configs for SeaMonkey 2.35

Comment 7

[Edmund Wong (:ewong)]

Attachment: update Configs for SeaMonkey 2.35 (v2)

Comment 8

[Edmund Wong (:ewong)]

Attachment: update Configs for SeaMonkey 2.35 (v3)

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 8650848 [details] [diff] [review]
update Configs for SeaMonkey 2.35 (v3)

Review of attachment 8650848 [details] [diff] [review]:
-----------------------------------------------------------------

r+ IFF you update the mozilla repo url for https://hg.mozilla.org/build/buildbot-configs/file/0c8016910462/seamonkey/config.py#l644 while you're here

Comment 10

[Edmund Wong (:ewong)]

Attachment: [configs] update Configs for SeaMonkey 2.35 (v4) [checked-in]

Comment 11

[Edmund Wong (:ewong)]

Comment on attachment 8650851 [details] [diff] [review]
[configs] update Configs for SeaMonkey 2.35 (v4) [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/59f4767266ad

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 8650848 [details] [diff] [review]
update Configs for SeaMonkey 2.35 (v3)

ewong landed: http://hg.mozilla.org/build/buildbot-configs/rev/59f4767266ad

Comment 13

[Justin Wood (:Callek)]

Attachment: [custom] don't fail if nothing-to-commit during bump [checked-in]

This bites us more than it helps us these days... Lets not fail out if we fail to bump.

Doing a post-landing review

Comment 14

[Edmund Wong (:ewong)]

Attachment: [custom] add py27 path to the uploadEnv['PATH']. (v1)

Comment 15

[Edmund Wong (:ewong)]

Comment on attachment 8651327 [details] [diff] [review]
[custom] add py27 path to the uploadEnv['PATH']. (v1)

this isn't the only thing that's needed.

Comment 16

[Edmund Wong (:ewong)]

Attachment: [custom] buildbotcustom code changes to fix source's upload tarball step (v1)

Comment 17

[Edmund Wong (:ewong)]

Attachment: [config] config code changes to fix source's upload tarball step (v1)

Comment 18

[Edmund Wong (:ewong)]

Attachment: [config] config code changes to fix source's upload tarball step (v1)

Comment 19

[Edmund Wong (:ewong)]

Attachment: [puppet] temp changes to puppet to whitelist rel-c-rel-source

this will be backed out once I figure out the source step.

Comment 20

[Edmund Wong (:ewong)]

Comment on attachment 8651448 [details] [diff] [review]
[config] config code changes to fix source's upload tarball step (v1)

needs more work.

Comment 21

[Edmund Wong (:ewong)]

Attachment: [custom] fix for source's upload_tarball step.

Comment 22

[Edmund Wong (:ewong)]

Attachment: [configs] fix for source's upload_tarball step [checked-in]

Comment 23

[Edmund Wong (:ewong)]

During the source step,  it choked on the upload_tarball step due to
it missing the proper python environment and that the way to upload
the tarball had changed.

The two patches I just attached 'work'; but will need to be streamlined.

Comment 24

[Edmund Wong (:ewong)]

Attachment: Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to build/unix/mozconfig.linux

This patch needs to be pushed to the SEAMONKEY_2_35_RELEASE branch.

Comment 25

[Edmund Wong (:ewong)]

Attachment: Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files.

This is for post-land-review.

Comment 26

[Edmund Wong (:ewong)]

Attachment: [c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

Comment 27

[Edmund Wong (:ewong)]

Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

Pushed to comm-release (SEAMONKEY_2_35_RELEASE_BRANCH):
https://hg.mozilla.org/releases/comm-release/rev/4c0855a2be32

Comment 28

[Edmund Wong (:ewong)]

Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

and this needs to be transplanted to the SEAMONKEY_2_36_RELEASE_BRANCH
as well. (tbd)

Comment 29

[Edmund Wong (:ewong)]

Attachment: Update configs for SeaMonkey 2.35 build 2 (v1)

Comment 30

[Edmund Wong (:ewong)]

Attachment: Update configs for SeaMonkey 2.35 build2 (v2)

Comment 31

[Justin Wood (:Callek)]

Comment on attachment 8652350 [details] [diff] [review]
Update configs for SeaMonkey 2.35 build2 (v2)

Review of attachment 8652350 [details] [diff] [review]:
-----------------------------------------------------------------

::: seamonkey/release-comm-release.py
@@ +38,5 @@
>  releaseConfig['mozillaRelbranchOverride']   = 'SEAMONKEY_2_35_RELEASE_BRANCH' # put Gecko relbranch here that we base upon
>  #   Inspector
>  releaseConfig['inspectorRepoPath']          = 'dom-inspector' # leave empty if inspector is not to be tagged
> +releaseConfig['inspectorRepoRevision']      = '8b0b7330d1d7'
> +releaseConfig['inspectorRelbranchOverride'] = 'SEAMONKEY_2_35_BUILD1'

as said in IRC r- for this

10:53 AM <•Callek_cloud9> ewong: r-  inspector relbranch should be SEA_COMM3820_20150821_RELBRANCH 
10:54 AM <•Callek_cloud9> and the rev should be the BUILD1

Comment 32

[Edmund Wong (:ewong)]

Attachment: [configs] Update configs for SeaMonkey 2.35 build2 (v3) [checked-in]

fixed.

Comment 33

[Edmund Wong (:ewong)]

Comment on attachment 8652363 [details] [diff] [review]
[configs] Update configs for SeaMonkey 2.35 build2 (v3) [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/08c45fc168fb

Comment 34

[Justin Wood (:Callek)]

Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

Review of attachment 8652146 [details] [diff] [review]:
-----------------------------------------------------------------

This one looks good, but isn't what you ended up landing. (you used the windows path on linux and mac)

Comment 35

[Edmund Wong (:ewong)]

Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

I had pushed to wrong patch, so the patch from http://hg.mozilla.org/releases/comm-release/rev/4c0855a2be32 is wrong.

Backed it out: https://hg.mozilla.org/releases/comm-release/rev/f23c75f0d371

Comment 36

[Edmund Wong (:ewong)]

Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

Pushed the real patch to comm-release:
https://hg.mozilla.org/releases/comm-release/rev/b939f5c5904d

Comment 37

[Edmund Wong (:ewong)]

Attachment: [configs] Update configs for SeaMonkey 2.35 build 3 (v1) [checked-in]

Due to the screwup with the Socorro symbol export mozconfig patch, we'll need a build 3.

Comment 38

[Edmund Wong (:ewong)]

Comment on attachment 8652649 [details] [diff] [review]
[configs] Update configs for SeaMonkey 2.35 build 3 (v1) [checked-in]

For post-land-review.

Comment 39

[Edmund Wong (:ewong)]

Comment on attachment 8652649 [details] [diff] [review]
[configs] Update configs for SeaMonkey 2.35 build 3 (v1) [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/eb3e0714774c

Comment 40

[Edmund Wong (:ewong)]

Attachment: [custom] fix for source's upload_tarball step. (v3) [unbitrot] [checked-in]

Comment 41

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #40)
> Created attachment 8655743 [details] [diff] [review]
> [custom] fix for source's upload_tarball step. (v3) [unbitrot]

Note. This and the [config] patches are manually applied.  Just unbitrotted
the custom patch due to changes from bug 1121281. (More patches to follow,
fwiw..)

Comment 42

[Edmund Wong (:ewong)]

Attachment: [puppet] temp patch to disable source clobber.

tl;dr,  basically the source step is still busted and this is because I mistakenly assumed the 'upload' source step == make upload; but it isn't.
c-r's suite's build.mk is missing source-upload:: rule.  

As this is a little too late in the process to fix any c-r issues, I've opted to disable the source clobber in puppet and will both manually generate the source tarball and upload it.

Comment 43

[Edmund Wong (:ewong)]

Attachment: [configs] fix for source's upload_tarball step (both release and beta) (v4)

Comment 44

[Edmund Wong (:ewong)]

Comment on attachment 8651564 [details] [diff] [review]
[configs] fix for source's upload_tarball step [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/f00ec9924207

Comment 45

[Edmund Wong (:ewong)]

Comment on attachment 8655743 [details] [diff] [review]
[custom] fix for source's upload_tarball step. (v3) [unbitrot] [checked-in]

Pushed to buildbotcustom:
https://hg.mozilla.org/build/buildbotcustom/rev/c0baa09149ae

Comment 46

[Edmund Wong (:ewong)]

Comment on attachment 8651007 [details] [diff] [review]
[custom] don't fail if nothing-to-commit during bump [checked-in]

Pushed to buildbotcustom:
https://hg.mozilla.org/build/buildbotcustom/rev/4f59415edea0

Comment 47

[rsx11m]

Comment on attachment 8651564 [details] [diff] [review]
[configs] fix for source's upload_tarball step [checked-in]

Clearing obsolete after-the-fact review request.

Comment 48

[rsx11m]

Comment on attachment 8652649 [details] [diff] [review]
[configs] Update configs for SeaMonkey 2.35 build 3 (v1) [checked-in]

Clearing obsolete after-the-fact review request.

Comment 49

[rsx11m]

Comment on attachment 8655743 [details] [diff] [review]
[custom] fix for source's upload_tarball step. (v3) [unbitrot] [checked-in]

Clearing obsolete after-the-fact review request.