Closed Bug 1177025 (SM2.35) Opened 5 years ago Closed 4 years ago

Tracking bug for build and release of SeaMonkey 2.35

Categories

(SeaMonkey :: Release Engineering, defect, P1)

SeaMonkey 2.35 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.35

People

(Reporter: philip.chee, Assigned: ewong)

References

(Depends on 1 open bug, )

Details

User Story

This is a tracking bug for Build and Release of SeaMonkey 2.35

We expect an actual release before the end of:
[  ] May 2015
[  ] June 2015
[  ] July 2015
[  ] August 2015
[✔ ] September 2015
[  ] Octember 2015

Attachments

(9 files, 13 obsolete files)

6.11 KB, patch
ewong
: review+
Details | Diff | Splinter Review
561 bytes, patch
ewong
: review+
Details | Diff | Splinter Review
927 bytes, patch
Details | Diff | Splinter Review
1.73 KB, patch
Details | Diff | Splinter Review
3.37 KB, patch
Callek
: review+
Details | Diff | Splinter Review
3.58 KB, patch
Callek
: review+
Details | Diff | Splinter Review
2.25 KB, patch
Details | Diff | Splinter Review
8.24 KB, patch
Details | Diff | Splinter Review
888 bytes, patch
Details | Diff | Splinter Review
This is a tracking bug for Build and Release of SeaMonkey 2.35

We expect an actual release before the end of June.
Depends on: 1172917
Depends on: SM2.35-Uplift
Depends on: SM235-RELNOTE
Depends on: 1177048
Depends on: 1177769
Depends on: 1177773
User Story: (updated)
Depends on: 1182957
Not sure where to put this note, but the patch for bug 1177634 has
to be uplifted to mozilla-esr38.
Depends on: 1177634
No longer depends on: SM2.35-mozilla-release-Uplift
Blocks: 1121281
No longer blocks: 1121281
Depends on: 1121281
User Story: (updated)
Octember 2015?  I think you mis-spelled this.  It should be "October" 2015.
But it's at the location of Julgust, thus needs to be corrected either way.
you mean "August", rsx11m?  ask ewong and see if he can get the information here corrected.  we really don't want to confuse the Seamonkey users about the upcoming SM 2.35 release.
No, I meant it in the same way as Ratty meant to say "Octember" as listed above.  ;-)
I'd have to read Dr. Seuss, but I don't think it's between July and August...
Attachment #8650843 - Flags: review?(bugspam.Callek)
Attachment #8650843 - Attachment is obsolete: true
Attachment #8650843 - Flags: review?(bugspam.Callek)
Attachment #8650846 - Flags: review?(bugspam.Callek)
Attachment #8650846 - Attachment is obsolete: true
Attachment #8650846 - Flags: review?(bugspam.Callek)
Attachment #8650848 - Flags: review?(bugspam.Callek)
Comment on attachment 8650848 [details] [diff] [review]
update Configs for SeaMonkey 2.35 (v3)

Review of attachment 8650848 [details] [diff] [review]:
-----------------------------------------------------------------

r+ IFF you update the mozilla repo url for https://hg.mozilla.org/build/buildbot-configs/file/0c8016910462/seamonkey/config.py#l644 while you're here
Attachment #8650848 - Flags: review?(bugspam.Callek) → review+
Attachment #8650851 - Flags: review?(bugspam.Callek) → review+
Attachment #8650848 - Attachment is obsolete: true
Comment on attachment 8650851 [details] [diff] [review]
[configs] update Configs for SeaMonkey 2.35 (v4) [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/59f4767266ad
This bites us more than it helps us these days... Lets not fail out if we fail to bump.

Doing a post-landing review
Attachment #8651007 - Flags: review?(ewong)
Attachment #8651007 - Flags: review?(ewong) → review+
User Story: (updated)
Attachment #8651327 - Flags: review?(bugspam.Callek)
Comment on attachment 8651327 [details] [diff] [review]
[custom] add py27 path to the uploadEnv['PATH']. (v1)

this isn't the only thing that's needed.
Attachment #8651327 - Flags: review?(bugspam.Callek)
Attachment #8651327 - Attachment is obsolete: true
Attachment #8651446 - Flags: review?(bugspam.Callek)
Attachment #8651447 - Flags: review?(bugspam.Callek)
Attachment #8651447 - Attachment is obsolete: true
Attachment #8651447 - Flags: review?(bugspam.Callek)
Attachment #8651448 - Flags: review?(bugspam.Callek)
Attachment #8651446 - Flags: review?(bugspam.Callek)
this will be backed out once I figure out the source step.
Comment on attachment 8651448 [details] [diff] [review]
[config] config code changes to fix source's upload tarball step (v1)

needs more work.
Attachment #8651448 - Flags: review?(bugspam.Callek)
Attachment #8651446 - Attachment is obsolete: true
Attachment #8651563 - Flags: review?(bugspam.Callek)
Attachment #8651448 - Attachment is obsolete: true
Attachment #8651564 - Flags: review?(bugspam.Callek)
During the source step,  it choked on the upload_tarball step due to
it missing the proper python environment and that the way to upload
the tarball had changed.

The two patches I just attached 'work'; but will need to be streamlined.
This patch needs to be pushed to the SEAMONKEY_2_35_RELEASE branch.
Attachment #8651578 - Flags: review?(bugspam.Callek)
This is for post-land-review.
Attachment #8651578 - Attachment is obsolete: true
Attachment #8651578 - Flags: review?(bugspam.Callek)
Attachment #8652143 - Flags: review?(bugspam.Callek)
Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

Pushed to comm-release (SEAMONKEY_2_35_RELEASE_BRANCH):
https://hg.mozilla.org/releases/comm-release/rev/4c0855a2be32
Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

and this needs to be transplanted to the SEAMONKEY_2_36_RELEASE_BRANCH
as well. (tbd)
Attachment #8652238 - Flags: review?(bugspam.Callek)
Attachment #8652238 - Attachment is obsolete: true
Attachment #8652238 - Flags: review?(bugspam.Callek)
Attachment #8652350 - Flags: review?(bugspam.Callek)
Comment on attachment 8652350 [details] [diff] [review]
Update configs for SeaMonkey 2.35 build2 (v2)

Review of attachment 8652350 [details] [diff] [review]:
-----------------------------------------------------------------

::: seamonkey/release-comm-release.py
@@ +38,5 @@
>  releaseConfig['mozillaRelbranchOverride']   = 'SEAMONKEY_2_35_RELEASE_BRANCH' # put Gecko relbranch here that we base upon
>  #   Inspector
>  releaseConfig['inspectorRepoPath']          = 'dom-inspector' # leave empty if inspector is not to be tagged
> +releaseConfig['inspectorRepoRevision']      = '8b0b7330d1d7'
> +releaseConfig['inspectorRelbranchOverride'] = 'SEAMONKEY_2_35_BUILD1'

as said in IRC r- for this

10:53 AM <•Callek_cloud9> ewong: r-  inspector relbranch should be SEA_COMM3820_20150821_RELBRANCH 
10:54 AM <•Callek_cloud9> and the rev should be the BUILD1
Attachment #8652350 - Flags: review?(bugspam.Callek) → review-
fixed.
Attachment #8652350 - Attachment is obsolete: true
Attachment #8652363 - Flags: review?(bugspam.Callek)
Attachment #8652363 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8652363 [details] [diff] [review]
[configs] Update configs for SeaMonkey 2.35 build2 (v3) [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/08c45fc168fb
Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

Review of attachment 8652146 [details] [diff] [review]:
-----------------------------------------------------------------

This one looks good, but isn't what you ended up landing. (you used the windows path on linux and mac)
Attachment #8652146 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

I had pushed to wrong patch, so the patch from http://hg.mozilla.org/releases/comm-release/rev/4c0855a2be32 is wrong.

Backed it out: https://hg.mozilla.org/releases/comm-release/rev/f23c75f0d371
Comment on attachment 8652146 [details] [diff] [review]
[c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]

Pushed the real patch to comm-release:
https://hg.mozilla.org/releases/comm-release/rev/b939f5c5904d
Due to the screwup with the Socorro symbol export mozconfig patch, we'll need a build 3.
Attachment #8652649 - Flags: review?(bugspam.Callek)
Comment on attachment 8652649 [details] [diff] [review]
[configs] Update configs for SeaMonkey 2.35 build 3 (v1) [checked-in]

For post-land-review.
Comment on attachment 8652649 [details] [diff] [review]
[configs] Update configs for SeaMonkey 2.35 build 3 (v1) [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/eb3e0714774c
User Story: (updated)
Attachment #8651563 - Attachment is obsolete: true
Attachment #8651563 - Flags: review?(bugspam.Callek)
Attachment #8655743 - Flags: review?(bugspam.Callek)
(In reply to Edmund Wong (:ewong) from comment #40)
> Created attachment 8655743 [details] [diff] [review]
> [custom] fix for source's upload_tarball step. (v3) [unbitrot]

Note. This and the [config] patches are manually applied.  Just unbitrotted
the custom patch due to changes from bug 1121281. (More patches to follow,
fwiw..)
tl;dr,  basically the source step is still busted and this is because I mistakenly assumed the 'upload' source step == make upload; but it isn't.
c-r's suite's build.mk is missing source-upload:: rule.  

As this is a little too late in the process to fix any c-r issues, I've opted to disable the source clobber in puppet and will both manually generate the source tarball and upload it.
Attachment #8655743 - Attachment is obsolete: true
Attachment #8655743 - Flags: review?(bugspam.Callek)
Attachment #8657007 - Flags: review?(bugspam.Callek)
Attachment #8655743 - Attachment is obsolete: false
Attachment #8655743 - Flags: review?(bugspam.Callek)
Attachment #8657007 - Attachment is obsolete: true
Attachment #8657007 - Flags: review?(bugspam.Callek)
Attachment #8650851 - Attachment description: update Configs for SeaMonkey 2.35 (v4) → update Configs for SeaMonkey 2.35 (v4) [checked-in]
Comment on attachment 8651564 [details] [diff] [review]
[configs] fix for source's upload_tarball step [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/f00ec9924207
Attachment #8651564 - Attachment description: [configs] fix for source's upload_tarball step → [configs] fix for source's upload_tarball step [checked-in]
Attachment #8652146 - Attachment description: Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) → Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]
Attachment #8652146 - Attachment description: Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in] → [c-r/mozconfigs] Add the SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE export to the necessary mozconfig files. (v3) [checked-in]
Attachment #8652363 - Attachment description: Update configs for SeaMonkey 2.35 build2 (v3) → [configs] Update configs for SeaMonkey 2.35 build2 (v3) [checked-in]
Attachment #8652649 - Attachment description: Update configs for SeaMonkey 2.35 build 3 (v1) → [configs] Update configs for SeaMonkey 2.35 build 3 (v1) [checked-in]
Comment on attachment 8655743 [details] [diff] [review]
[custom] fix for source's upload_tarball step. (v3) [unbitrot] [checked-in]

Pushed to buildbotcustom:
https://hg.mozilla.org/build/buildbotcustom/rev/c0baa09149ae
Attachment #8655743 - Attachment description: [custom] fix for source's upload_tarball step. (v3) [unbitrot] → [custom] fix for source's upload_tarball step. (v3) [unbitrot] [checked-in]
Comment on attachment 8651007 [details] [diff] [review]
[custom] don't fail if nothing-to-commit during bump [checked-in]

Pushed to buildbotcustom:
https://hg.mozilla.org/build/buildbotcustom/rev/4f59415edea0
Attachment #8651007 - Attachment description: [custom] don't fail if nothing-to-commit during bump → [custom] don't fail if nothing-to-commit during bump [checked-in]
Attachment #8650851 - Attachment description: update Configs for SeaMonkey 2.35 (v4) [checked-in] → [configs] update Configs for SeaMonkey 2.35 (v4) [checked-in]
Blocks: SM2.38
Depends on: 1209484
Comment on attachment 8651564 [details] [diff] [review]
[configs] fix for source's upload_tarball step [checked-in]

Clearing obsolete after-the-fact review request.
Attachment #8651564 - Flags: review?(bugspam.Callek)
Comment on attachment 8652649 [details] [diff] [review]
[configs] Update configs for SeaMonkey 2.35 build 3 (v1) [checked-in]

Clearing obsolete after-the-fact review request.
Attachment #8652649 - Flags: review?(bugspam.Callek)
Comment on attachment 8655743 [details] [diff] [review]
[custom] fix for source's upload_tarball step. (v3) [unbitrot] [checked-in]

Clearing obsolete after-the-fact review request.
Attachment #8655743 - Flags: review?(bugspam.Callek)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.