Closed Bug 1177044 Opened 9 years ago Closed 9 years ago

[Contacts][NGA] Move view() and utility() from contacts.js to a separate class

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S2 (10Jul)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: jorgep, Assigned: jorgep)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(2 files)

30700.html
384 bytes, text/html
borjasalguero
: review+
borjasalguero
: feedback+
Details
[gaia] jpruden92:bug_separate-loader > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review 
On contacts there are a lot of dependencies related with the async load of views and utilities. This operation is done by view() and utility() functions in contacts.js. To reduce separate dependencies we should extract these functions to a separate class.
Attached file 30700.html — 

        Attachment #8625684 -
        Flags: feedback?(borja.bugzilla)

    
  
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8625684 [details]
30700.html

Great job Jorge! I've left some comments in Github (lot of them related with the same code), so let me know when ready and I'll review the final patch! Gracias! :)

        Attachment #8625684 -
        Flags: feedback?(borja.bugzilla) → feedback+

    
  

        Attachment #8625684 -
        Flags: review?(francisco)

        Attachment #8625684 -
        Flags: review?(borja.bugzilla)
Target Milestone: FxOS-S1 (26Jun) → FxOS-S2 (10Jul)

    
    

    
  
Comment on attachment 8625684 [details]
30700.html

Some comments to be addressed. Could you take a look? Ask me to review this again when ready. Thanks! :)

        Attachment #8625684 -
        Flags: review?(borja.bugzilla)

    
    

    
  
Comment on attachment 8625684 [details]
30700.html

r+ once the comments from Borja are addressed and the jsdoc has been added.

Good job!

        Attachment #8625684 -
        Flags: review?(francisco) → review+

    
  

        Attachment #8625684 -
        Flags: review+ → review?(borja.bugzilla)
Target Milestone: FxOS-S2 (10Jul) → FxOS-S3 (24Jul)

        Attachment #8625684 -
        Flags: review?(borja.bugzilla) → review+
Target Milestone: FxOS-S3 (24Jul) → FxOS-S2 (10Jul)

    
  
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: