1177107 - Cannot save or update a new contact via activity if it has a picture

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Maria Angeles Oteo (:oteo)]

STR:
1.Open Dialer application
2.Enter a number in the dialpad
3.Add it to the Agenda and select "Create new contact" or "Add to existing Contact" options.
4.Add a picture to the contact and press "Done" button in order to save it

Actual Result: the contact is not saved, the action does not finish
Expected Result: the contact is saved and added to the Agenda

Note: In case we want to create or update a contact from Contacts application, the issue is not reproduced. It's necessary creating the contact via activity (e.g. from Dialpad, Call Log or SMS applications)

Environmental variables:
flame master (3.0 version)
Build ID: 20150624055939
Gecko: 87e3154
Gaia: eb0d4ae
Platform version: 41.0a1

Comment 1

[Johan Lorenzo [:jlorenzo]]

I have the feeling it's a regression. QA wanted for a branch check.

Comment 2

[Maria Angeles Oteo (:oteo)]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #1)
> I have the feeling it's a regression. QA wanted for a branch check.

You are right, I can not reproduce it in 2.2 branch

Environmental variables:
flame master (2.2 version)
Build ID: 20150624051721
Gecko: 8092f0c
Gaia: 1f8981d
Platform version: 27.0

Comment 3

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Regression

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comms triage: Broken functionality.

Comment 5

[Maria Angeles Oteo (:oteo)]

Borja is fixing this issue in the WIP patch included in bug 1175575 so let's wait it lands in master to confirm that the bug is fixed.

Comment 6

[Borja Salguero [:borjasalguero]]

M.Angeles, could you check if this is fixed? #new activity has just landed. Thanks!!

Comment 7

[Maria Angeles Oteo (:oteo)]

Unfortunately, it's not fixed yet, I am able to reproduce the bug very often.

Anyway, when reporting the bug I didn't include all the consequences of not been able to save the contact from an activity. The worst is that after reproducing the issue you need to kill the application where the activity was launched (in this case, Dialer). 

Here, I include the complete steps and the results BEFORE LANDING bug 1175575

STR:
1.Open Dialer application
2.Enter a number in the dialpad
3.Add it to the Agenda and select "Create new contact" option.
4.Add a picture to the contact and press "Done" button in order to save it (via camera or gallery)

Actual Result: the contact is not saved, the action does not finish
Expected Result: the contact is saved and added to the Agenda

After the fault:
5. Close the create new contact screen, upper-left button (x), to go back to the Dialpad.
6. Again, try to add the entered number in the Dialpad to the Agenda ("Create new contact" option)

Actual Result: Black screen. It’s necessary to kill Dialer application to be able to use it again.

Some Notes: 
* I don't have a reproduction rate, but it's easy to see (specially when attaching a photo from the Camera)
* Sometimes, after attaching the picture and before trying to save the contact, the menu labels stop working. It seems associated to the same bug but perhaps we should open a different bug for this issue.

Environmental variables:
flame master (2.5.0 version)
Build ID: 20150709050821
Gecko: 60fd820
Gaia: b0791fe
Platform version: 42.0a1

Comment 8

[Maria Angeles Oteo (:oteo)]

AFTER LANDING bug 1175575, the STR and the results are the same but after step 4, the result has changed (at least the UI)

Actual Result: Now, after landing bug 1175575, the contact is not saved when "Done" button is pressed and before landing bug 1175575, the action didn't finish.

I have included a video with the current behaviour after landing bug 1175575: https://youtu.be/Y1PLorZ2gxI

Environmental variables:
flame master (2.5.0 version)
Build ID: 20150710111855
Gecko: 2c7068c
Gaia: c77dffd
Platform version: 42.0a1

Comment 9

[Maria Angeles Oteo (:oteo)]

We have doubts about the builds we are generating in Telefonica, some of us are not reproducing this fault after doing make reset-gaia. For that reason, setting qawanted keyword to confirm if the bug is also seen by QA team. Thanks a lot!

Comment 10

[KTucker [:KTucker][Inactive 3/4/2016]]

I could not reproduce this issue after several attempts on the Flame and Aries devices.

The contact always saved properly whether I created a new one or added to an existing one from a number that I dialed in dialer. 

Device: Flame 2.5 (Full Flash)(KK)(319mb)
BuildID: 20150713010204 
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: eab21ec484bb
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Environmental Variables:
Device: Aries 2.5
BuildID: 20150619225606
Gaia: 4c06ed88ddccaba8dc941e5006bd2a9e57306f07
Gecko: 7c1a6b1151a1539186b950a144387e2d7f378d1b
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 41.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 11

[KTucker [:KTucker][Inactive 3/4/2016]]

Correction to the Aries environmental variables:

Device: Aries 2.5
BuildID: 20150713103207
Gaia: a7439b6ca88264734171ff5ea0b6a0b8df3f258e
Gecko: 38d03bf4616e
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Checked this and could not reproduce.

Closing as works for me, if you see it happening again, please reopen.

Comment 13

[Carmen Jimenez Cabezas]

Attachment: adb.patch

I've reproduced this bug too, but it looks as a race condition related with first run, because if the phone is flashed, you execute the STR and the error happens, then the error will happen every time, but if after first run and executing STR you can't reproduce it, it won't happen at any time.

The problem that you can find is that to catch the traces you need to have adb active at boot time, and by default that's not the case (and even less on production builds). I've attached a small patch that you can use to enable this.