Provide a button to re-enable Tracking Protection in about:privatebrowsing

VERIFIED FIXED in Firefox 42

Status

()

Firefox
Private Browsing
P1
normal
Rank:
16
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: MattN, Assigned: Paolo)

Tracking

unspecified
Firefox 42
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify +

Firefox Tracking Flags

(firefox42 verified)

Details

(Whiteboard: [fxprivacy] [strings] [campaign])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Add a link to about:privatebrowsing so users can disable tracking protection in private browsing.

Depending on the about page flags we may not be able to directly link to the page and instead could use UITour (after whitelisting the page) for this.
Flags: firefox-backlog+
Hi Matt, is Bug 1177156 related to any of the user stories?
Flags: needinfo?(MattN+bmo)
Yep, bug 1175014, not sure how I missed that.
Blocks: 1175014
Flags: needinfo?(MattN+bmo)

Updated

2 years ago
Rank: 16
Priority: -- → P1

Updated

2 years ago
Flags: qe-verify+
(Assignee)

Comment 3

2 years ago
Taking this bug as well, since it's closely related to bug 1177152.
Assignee: nobody → paolo.mozmail
Iteration: --- → 42.1 - Jul 13

Updated

2 years ago
Status: NEW → ASSIGNED

Updated

2 years ago
Depends on: 1179850

Updated

2 years ago
QA Contact: mwobensmith

Updated

2 years ago
Iteration: 42.1 - Jul 13 → 42.2 - Jul 27
(Assignee)

Comment 4

2 years ago
Repurposing this bug to handle the case described in bug 1177152 comment 33:

https://www.dropbox.com/s/tg3ux7iss856k7a/TP-disabled-built-in-page?dl=0
Summary: Add a link to privacy preferences from about:privatebrowsing → Differentiate tour and preferences link in about:privatebrowsing based on whether TP is enabled
(Assignee)

Comment 5

2 years ago
Created attachment 8634694 [details]
MozReview Request: Bug 1177156 - Provide a button to re-enable Tracking Protection in about:privatebrowsing. r=ttaubert

Bug 1177156 - Differentiate tour and preferences link in about:privatebrowsing based on whether TP is enabled. r=ttaubert
Attachment #8634694 - Flags: review?(ttaubert)

Comment 6

2 years ago
Can you ping me when you're ready to start on this because I want to clean up the visual design of this page since we decided on this so quickly yesterday...
(Assignee)

Comment 7

2 years ago
(In reply to agrigas from comment #6)
> Can you ping me when you're ready to start on this because I want to clean
> up the visual design of this page since we decided on this so quickly
> yesterday...

Yesterday's mockup is already implemented, but it will be easy to make changes if you want to share a cleaned up design!

Comment 8

2 years ago
(In reply to :Paolo Amadini from comment #7)
> (In reply to agrigas from comment #6)
> > Can you ping me when you're ready to start on this because I want to clean
> > up the visual design of this page since we decided on this so quickly
> > yesterday...
> 
> Yesterday's mockup is already implemented, but it will be easy to make
> changes if you want to share a cleaned up design!

Ok I'll post something in the morning since I need to review it today with a visual designer...
Comment on attachment 8634694 [details]
MozReview Request: Bug 1177156 - Provide a button to re-enable Tracking Protection in about:privatebrowsing. r=ttaubert

https://reviewboard.mozilla.org/r/13433/#review12127

LGTM, but waiting for Ash to get back with the final design.
Attachment #8634694 - Flags: review?(ttaubert)

Comment 10

2 years ago
(In reply to Tim Taubert [:ttaubert] from comment #9)
> Comment on attachment 8634694 [details]
> MozReview Request: Bug 1177156 - Differentiate tour and preferences link in
> about:privatebrowsing based on whether TP is enabled. r=ttaubert
> 
> https://reviewboard.mozilla.org/r/13433/#review12127
> 
> LGTM, but waiting for Ash to get back with the final design.

Here's the final design. It may need copy review but Matej is still out so will have to do for now.
https://www.dropbox.com/s/tg3ux7iss856k7a/TP-disabled-built-in-page?dl=0
(Assignee)

Comment 11

2 years ago
(In reply to agrigas from comment #10)
> Here's the final design. It may need copy review but Matej is still out so
> will have to do for now.
> https://www.dropbox.com/s/tg3ux7iss856k7a/TP-disabled-built-in-page?dl=0

Hm, so the "Turn on Tracking Protection" button would flip the preference rather than going to the Privacy Preferences, and the the user would see the version of the page with the "See what's new" button again?

Comment 12

2 years ago
(In reply to :Paolo Amadini from comment #11)
> (In reply to agrigas from comment #10)
> > Here's the final design. It may need copy review but Matej is still out so
> > will have to do for now.
> > https://www.dropbox.com/s/tg3ux7iss856k7a/TP-disabled-built-in-page?dl=0
> 
> Hm, so the "Turn on Tracking Protection" button would flip the preference
> rather than going to the Privacy Preferences, and the the user would see the
> version of the page with the "See what's new" button again?

Yes. We want to encourage people to use this feature - its something Firefox is recommended is the best private browsing experience so having it easy to turn back on, in case it got turned off accidentally or by someone else using your browser, we think is important.
(Assignee)

Comment 13

2 years ago
(In reply to agrigas from comment #12)
> Yes. We want to encourage people to use this feature - its something Firefox
> is recommended is the best private browsing experience so having it easy to
> turn back on, in case it got turned off accidentally or by someone else
> using your browser, we think is important.

Okay, thanks for explaining the rationale!
(Assignee)

Comment 14

2 years ago
Comment on attachment 8634694 [details]
MozReview Request: Bug 1177156 - Provide a button to re-enable Tracking Protection in about:privatebrowsing. r=ttaubert

Bug 1177156 - Provide a button to re-enable Tracking Protection in about:privatebrowsing. r=ttaubert
Attachment #8634694 - Attachment description: MozReview Request: Bug 1177156 - Differentiate tour and preferences link in about:privatebrowsing based on whether TP is enabled. r=ttaubert → MozReview Request: Bug 1177156 - Provide a button to re-enable Tracking Protection in about:privatebrowsing. r=ttaubert
Attachment #8634694 - Flags: review?(ttaubert)
(Assignee)

Comment 15

2 years ago
Updated to provide the button and added a test for it, should be ready for review.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08c37be952f5
Summary: Differentiate tour and preferences link in about:privatebrowsing based on whether TP is enabled → Provide a button to re-enable Tracking Protection in about:privatebrowsing
Attachment #8634694 - Flags: review?(ttaubert) → review+
Comment on attachment 8634694 [details]
MozReview Request: Bug 1177156 - Provide a button to re-enable Tracking Protection in about:privatebrowsing. r=ttaubert

https://reviewboard.mozilla.org/r/13433/#review12217

r=me with the two tiny issues fixed.

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js:125
(Diff revision 2)
> +        prefBranch.removeObserver("enabled", prefObserver, false);

removeObserver() doesn't take a third argument.

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js:129
(Diff revision 2)
> +    prefBranch.addObserver("enabled", prefObserver, false);

So it's not actually added as a weak ref, good. Then we'll just have to remove the extra QI entry above.

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js:121
(Diff revision 2)
> +    let prefObserver = {
> +      QueryInterface : XPCOMUtils.generateQI([Ci.nsIObserver,
> +                                              Ci.nsISupportsWeakReference]),
> +      observe: function () {

This must not be a weak ref or we'll create another intermittent failure. Nothing holds onto |prefObserver|.
(Assignee)

Comment 17

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/34427253904c

Comment 18

2 years ago
https://www.dropbox.com/s/tg3ux7iss856k7a/TP-disabled-built-in-page?dl=0

New version based on Matej's copy feedback
(Assignee)

Updated

2 years ago
Blocks: 1185528
https://hg.mozilla.org/mozilla-central/rev/34427253904c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Duplicate of this bug: 1185825

Updated

2 years ago
Whiteboard: [fxprivacy] [strings] → [fxprivacy] [strings] [campaign]
Verified in Nightly 42.0a1, 2015-07-27.
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.