1177178 - When connecting to Wifi, the icon moves slightly as the connecting animation plays

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sevaan Franks [:sevaan]]

When connecting to a wifi network, the wifi icon next to the network name shifts positions slightly as the connecting animation plays. It should stay put.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Amy can you provide a new graphic, its a pretty annoying polish bug. I believe Pavel can merge it in for you.

Comment 2

[Amy Lee [:amylee] UX]

Attachment: [e-mail]

Hi Pavel, 

Can you replace the @2.25 scale wifi sprites and send me a UI review? Just want to make sure there's no shifting in the new sprites before rolling out the rest of the sizes. Thanks!

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] pivanov:bug-1177178 > mozilla-b2g:master

Comment 4

[Amy Lee [:amylee] UX]

Attachment: Wifi_Sprites.zip

Wifi sprites in @1, @1.5, @2, @2,25 scale

Comment 5

[Amy Lee [:amylee] UX]

Comment on attachment 8649446 [details] [review]
[gaia] pivanov:bug-1177178 > mozilla-b2g:master

These look good! Can you please update the rest of the sizes? Thanks

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8649446 [details] [review]
[gaia] pivanov:bug-1177178 > mozilla-b2g:master

Hey Vincent,
can I ask you for r+?

Comment 7

[Vincent Chang[:vchang][changyihsin]]

Hey Pavel, I am not a qualified reviewer for gaia application, you should try gaia expert.

Comment 8

[Evelyn Hung]

Comment on attachment 8649446 [details] [review]
[gaia] pivanov:bug-1177178 > mozilla-b2g:master

visual change, rubberstamp! Thank you.

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/894ae4a85735520163393c005f9a2607bbe764db