Stop printing hg and git errors to web logs

RESOLVED FIXED

Status

Webtools
DXR
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: erik, Assigned: new_one)

Tracking

Trunk

Firefox Tracking Flags

(firefox41 affected)

Details

(Reporter)

Description

2 years ago
In vcs.py, we run the version-control commands with just subprocess.check_output(). This causes all the (expected) failures to be dumped into the Apache logs. Let's swallow expected "failures" by redirecting the output, likely stderr. One of the other subprocess routines, like call(), might serve.
said errors, in case it helps:

abort: no repository found in '/src/rust' (.hg not found)!
abort: no repository found in '/src/rust/src/libcollections' (.hg not found)!
fatal: Path 'src/libcollections/slice.rs' exists, but not 'slice.rs'.
Did you mean '6065bed37be55427ed0ac888b863a85696b28f9b:src/libcollections/slice.rs' aka '6065bed37be55427ed0ac888b863a85696b28f9b:./slice.rs'?

Comment 2

2 years ago
Commit pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/21d08150a7608285d0a054775ca772c76e2d87a0
Fix bug 1177191, pass devnull as the stderr stream for get_contents.

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 3

2 years ago
Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/21d08150a7608285d0a054775ca772c76e2d87a0
Fix bug 1177191, pass devnull as the stderr stream for get_contents.
You need to log in before you can comment on or make changes to this bug.