1177201 - Saving pictures doesn't always prompt for Photos permission

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Richard Newman [:rnewman]]

A user reported that he can't save pictures, was never prompted for the appropriate permission, and doesn't see it in Settings > Firefox.

We should double check that we're requesting that permission.

Comment 1

[allenngn]

Attachment: Pull request

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Than you very much for this patch :allengn!

I am cleaning this up so that we can land this today. Just changing the strings to be localized.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Screenshot 2015-07-08 13.44.43.png

Screenshot for localizers

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/689

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8631132 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/689

Looks good to me - just left a comment about checking to see if we get an error back from the UIImageWriteToSavedPhotosAlbum method.

Comment 6

[Stefan Plewako [:stef]]

Is camera roll still present in current iOS?

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Yes, Camera Roll is the 'global' Album that contains all photos.

Comment 8

[Stefan Plewako [:stef]]

If you use iCloud Photo Library there seems to be no Camera Roll album at all, there is All Photos album instead - maybe we could reword this to be more general and handle both cases?