1177258 - [Video] When opening a video from a notification there is debug text and a red box around the pause button that is visible for a second.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
If a user receives a video from bluetooth or NFC there will be a notification that they receive for the video. If they use the notification to open the video they will see A red box around the pause button and debug text that will disappear quickly.

Repro Steps:
1) Update a Flame to 20150622160206
2) Transfer a video to the device using NFC or bluetooth
3) Open notification center
4) Select the notification for the transferred file
5) Observe pause button

Actual:
A red box is arond the pause button and there is debug text visible

Expected:
It is expected that users cannot see debug text or red boxes anywhere

Environmental Variables:
Device: Aries 3.0 (Full Flash)
BuildID: 20150624143841
Gaia: eb0d4aefa62b20420d6fa0642515a110daca5d97
Gecko: 4cdc1a95a672
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 41.0a1 (3.0) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Repro frequency: 10/10
See attached: video clip(http://youtu.be/ineZCsOsj_M), logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 3.0.

Environmental Variables:
Device: Flame 3.0 (Full Flash)
Build ID: 20150622160206
Gaia: 311c4e59936a407e64509f54fecb440d8a78e3c8
Gecko: be81b8d6fae9
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Result:
A red box is around the pause button and there is debug text visible
---------------------------------------------------------
This issue DOES NOT occur on Flame 2.2.

Environmental Variables:
Device: Flame 2.2 (Full Flash)
BuildID: 20150624002503
Gaia: 1f8981d7872e3c0053571c26fb3edaf401844d75
Gecko: 3268ab642b70
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
The video preview opens as expected.

Comment 2

[Oliver Nelson [:oliverthor]]

[Blocking Requested - why for this release]:
Easily observed issue that is quickly dismissed, but reveals debug text.

Adding regressionwindow-wanted tag

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

The changes for Bug 1162040 seem to have caused this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150615060342
Gaia: 7dda863fb006fd3cb77c8e92aec739b2f829115b
Gecko: a52e8b0ac3d5
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150615064342
Gaia: 7a068be308f6b6429b2af79bac89a982e6c18d49
Gecko: 1117e929e06c
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 7dda863fb006fd3cb77c8e92aec739b2f829115b
Gecko: 1117e929e06c

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: 7a068be308f6b6429b2af79bac89a982e6c18d49
Gecko: a52e8b0ac3d5

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/7dda863fb006fd3cb77c8e92aec739b2f829115b...7a068be308f6b6429b2af79bac89a982e6c18d49

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Yura, here is another one that looks to be caused by the work done for bug 1162040.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Clearing ni as it is indeed my regression.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 7

[Russ Nicoletti [:russn]]

Comment on attachment 8628286 [details] [review]
Github pull request.

Looks good and I have verified it solves the problem. Thanks.

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/c2fec253b932bbbfb0e0c158d0dbe26e672a6b4b

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest nightly build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Opening a video from notification bar, there is no any debug text or red box around the 'Pause' button. 
See attachment: verified_Flame_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150803150205
Gaia Revision          dbacf8364f4505d021b7d8fb9cabea325004dbcc
Gaia Date              2015-08-03 16:38:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/abc56d57f6e1
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150803.183149
Firmware Date          Mon Aug  3 18:32:00 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150803195455
Gaia Revision          dbacf8364f4505d021b7d8fb9cabea325004dbcc
Gaia Date              2015-08-03 16:38:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/abc56d57f6e1
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150803.191800
Firmware Date          Mon Aug  3 19:18:08 UTC 2015
Bootloader             s1

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.3gp