Add WebGLFormat format tables

RESOLVED FIXED in Firefox 42

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
Created attachment 8625968 [details] [diff] [review]
solo-formats.diff

Let's just get the data in the tree so we can start using it, even if we haven't switched everything over yet.
Attachment #8625968 - Flags: review?(dglastonbury)
(Assignee)

Updated

3 years ago
Assignee: nobody → jgilbert
Attachment #8625968 - Flags: review?(dglastonbury) → review+
(Assignee)

Comment 1

3 years ago
Created attachment 8626700 [details] [diff] [review]
0002-Get-it-compiling.patch
Attachment #8626700 - Flags: review?(dglastonbury)
Comment on attachment 8626700 [details] [diff] [review]
0002-Get-it-compiling.patch

Review of attachment 8626700 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this took so long.
Attachment #8626700 - Flags: review?(dglastonbury) → review+
OK, I pulled the patch locally and it doesn't compile on OS X at all. After fixing uint8_t/uint16_t issue, compilation dies on std::initializer_list. Grepping the code base, it appears to not be used by any gecko code. Could we do this with out the use of std::initializer_list?
(Assignee)

Comment 4

3 years ago
(In reply to Dan Glastonbury :djg :kamidphish from comment #3)
> OK, I pulled the patch locally and it doesn't compile on OS X at all. After
> fixing uint8_t/uint16_t issue, compilation dies on std::initializer_list.
> Grepping the code base, it appears to not be used by any gecko code. Could
> we do this with out the use of std::initializer_list?

I was told this might happen.
(Assignee)

Comment 5

3 years ago
Created attachment 8628519 [details] [diff] [review]
0003-Make-it-compiler-portable.patch
Attachment #8628519 - Flags: review?(dglastonbury)
Attachment #8628519 - Flags: review?(dglastonbury) → review+
Have you bounced these patch off of Try?
(Assignee)

Comment 8

3 years ago
Created attachment 8630754 [details] [diff] [review]
0004-more.patch
Attachment #8630754 - Flags: review?(dglastonbury)
Comment on attachment 8630754 [details] [diff] [review]
0004-more.patch

Review of attachment 8630754 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLFormats.cpp
@@ +475,5 @@
>  }
>  
> +//////////////////////////////////////////////////////////////////////////////////////////
> +//////////////////////////////////////////////////////////////////////////////////////////
> +//////////////////////////////////////////////////////////////////////////////////////////

O_O
Attachment #8630754 - Flags: review?(dglastonbury) → review+
Excellent, it compiles. I'd recommend adding debug tests to your try push next, to be sure you don't leak a Mutex in mochitests and crashtests and mochitest-dt.

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/97b92a4f10ab
https://hg.mozilla.org/mozilla-central/rev/97c42d4fbdb1
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.