1177341 - Bookmarks favicon of twitter sometimes becomes black

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[atlanto]

Steps to reproduce:
1. Start firefox with new profile
2. Open twitter page (e.g. https://twitter.com/firefox) and bookmark it
3. View bookmarks sidebar (favicon is blue)
4. Preferences->Privacy, choose 'Use custom settings for history' and 'Clear history when Nightly closes'
5. Restart firefox
6. Click the bookmark
=> bookmark favicon becomes black

Another STR:
1. Open twitter page from bookmark
2. Open 'Clear Recent History' dialog
3. Choose 'Everything' and 'Browsing & Download History', click 'Clear Now'
4. Click the bookmark
=> bookmark favicon becomes black

I have this issue without clearing history but clearing history makes this issue 100% reproducible.

btw, firefox seems to be processing all favicons in a page(black svg and blue ico in this case), so I can see them like a flush or a wink(blue->black->blue) in the bookmarks sidebar frequently. It should be one favicon per page, imo.

Comment 1

[Alice0775 White]

this seems places.sqlite is corrupted due to Bug 1174552

Comment 2

[Alice0775 White]

Reproduced.
https://hg.mozilla.org/mozilla-central/rev/4cdc1a95a672
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0 ID:20150624080416

STR
1. Start with new profile
2. Open twitter ( e.g  https://twitter.com/saneyuki_s )
3. Ctrl+B to open bookmarks sidebar
   --- you can see black fabicon ---- BUG
4. Ctrl+Shift+Del and Choose 'Everything' and 'Browsing & Download History', click 'Clear Now'
5. Restart browser
  --- you can see black fabicon ---- as before
2. Open twitter again( e.g  https://twitter.com/saneyuki_s again)
  --- you can see blue fabicon ---- as expected

Comment 3

[Marco Bonardo [:mak]]

How does this differ from bug 1174552?
An existing icon will expire in a week (I seem to rememeber you can also force reload a page to make it expire sooner).
I don't think there's anything we should do here.

Comment 4

[Alice0775 White]

(In reply to Marco Bonardo [::mak] from comment #3)
> How does this differ from bug 1174552?
> An existing icon will expire in a week (I seem to rememeber you can also
> force reload a page to make it expire sooner).
> I don't think there's anything we should do here.

Tab's icon is blue in step 2. But, Black favicon is bookmarked after doing step3.
so, I think that this is Firefox Bug. (discrepancy between tab's icon and Bookmarks favicon)

Comment 5

[Marco Bonardo [:mak]]

One comes from the network, the other one from the database. I'm pretty sure once the database icon expires everything will be fine. not a big deal.

Comment 6

[Marco Bonardo [:mak]]

I think in the end this boils down to bug 418144, that is allowing the users to refresh favicons before their natural expiration. That's the bug.
This bug is currently WFM since I think twitter fixed their website. Or it could be a dupe of Bug 418144, in the sense there's nothing we can do here).