Closed Bug 1177378 Opened 5 years ago Closed 5 years ago

Exposure of links broken for VoiceOver

Categories

(Core :: Disability Access APIs, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox39 --- wontfix
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

This is a very recent regression: I noticed it while testing the try build for bug 744790, but also in the 2015-06-24 Nightly build. Other control types such as text boxes, check boxes, buttons etc. work, but for links, VoiceOver recently started to say "main", and it also speaks the word "main" far more often than it used to.

If you have an idea where this comes from, fine. If not, I'll find the regression range later. But I know that recently, this still worked fine, when I was testing the MathML exposure stuff. So this can't be more than 1 or 2 weeks old.

Steps are simple: Open any page that has links and navigate through with VoiceOver+RightArrow.
It was already broken on the 2015-06-19 nightly build, where bug 1150510 was fixed. The crashes prevent me from finding a regression range from before that, sorry! I'm afraid you'll have to debug this. :(
Attached patch Partial revert of bug 1137714 (obsolete) — Splinter Review
This fixes the problem. And no, I don't know why. Just followed a hunch, and it worked.
Attachment #8626379 - Flags: review?(surkov.alexander)
This fixes the problem, and landmarks etc. still work.
Assignee: nobody → mzehe
Attachment #8626379 - Attachment is obsolete: true
Attachment #8626379 - Flags: review?(surkov.alexander)
Attachment #8626391 - Flags: review?(surkov.alexander)
Comment on attachment 8626391 [details] [diff] [review]
Only search for the sub role's mapping if subrole isn't NIL

Review of attachment 8626391 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.mm
@@ +779,5 @@
>      return utils::LocalizedString(NS_LITERAL_STRING("htmlContent"));
>  
>    NSString* subrole = [self subrole];
>  
> +if (subrole) {

nit: pls indent it
Attachment #8626391 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/7214ce01cee5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8626391 [details] [diff] [review]
Only search for the sub role's mapping if subrole isn't NIL

Approval Request Comment
[Feature/regressing bug #]: bug 1137714, only uncovered after fix for bug 1150510
[User impact if declined]: Links and other elements will not be properly identified by VoiceOver on OS X.
[Describe test coverage new/current, TreeHerder]: Manual testing, is in Central.
[Risks and why]: No risk, basically a null check.
[String/UUID change made/needed]: None.
Attachment #8626391 - Flags: approval-mozilla-beta?
Attachment #8626391 - Flags: approval-mozilla-aurora?
Comment on attachment 8626391 [details] [diff] [review]
Only search for the sub role's mapping if subrole isn't NIL

Not sure that it is the correct patch in bugzilla (indent issue) but I am sure that the sheriff won't use it.

Anyway, taking it to aurora as we want to improve the accessibility but not in beta (or release) as 39 is going to go live next week.
Attachment #8626391 - Flags: approval-mozilla-beta?
Attachment #8626391 - Flags: approval-mozilla-beta-
Attachment #8626391 - Flags: approval-mozilla-aurora?
Attachment #8626391 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.