1177382 - Error is thrown by controller.jsm each time a URL is dragged onto the Bookmarks Toolbar

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P3)

Description

[Andrei Vaida [:avaida]]

Reproducible on:
* 31.8 ESR Build 1 (20150624141335)
* 39.0 RC Build 4 (20150624153222)
* Aurora 40.0a2 (2015-06-24)
* Nightly 41.0a1 (2015-06-24)

Steps to reproduce:
1. Launch Firefox.
2. Enable the Bookmarks Toolbar.
3. Open a random website that's currently _not_ bookmarked.
4. Drag and drop its URL onto the Bookmarks Toolbar.
5. Check the Browser Console for js errors.

Expected result:
There are no issues nor errors encountered for this action.

Actual result:
controller.js:1621 throws the following error in the Browser Console:
> Tried to move an unmovable Places node, reverting to a copy operation.

Additional notes:
* This is _not_ a recent regression, as I've managed to track it back to Firefox 30.0 (20140605174243) so far. I'll follow up with a detailed regression range as soon as possible.

Comment 1

[Andrei Vaida [:avaida]]

Regression range (m-c)
======================
Last good revision: ab137ddd3746 (2014-11-13)
First bad revision: 7f0d92595432 (2014-11-14)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ab137ddd3746&tochange=7f0d92595432

Potential regressor:
a4d2e72afc42 - Tim Taubert — Bug 1083462 - Remove the bookmarks cache r=mak

Comment 2

[Ton [:Tonnes]]

Just saw this occurring in 54.0.1.

Comment 3

[Mark Banner (:standard8)]

Generally there's no harm in this error - it is just a warning for developers. It will, however, occur every time when dragging some text like URL test onto the toolbar as per comment 0 (and maybe the same for into the library window). There's no harm in it though.

Comment 4

[Mark Banner (:standard8)]

There's a fix for this in bug 1439697.

Comment 5

[Mark Banner (:standard8)]

Fixed by bug 1439697.