1177388 - [e10s] ContentCache should be separated as two clasesses

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(no pain of the broken bone, but the corset blocks me to concentrate)]

I realized that ContentCache will be bigger than now for storing contents in parent.

So, for keeping the footprint in child process, we should create ContentCacheInParent class which is derived from ContentCache.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(no pain of the broken bone, but the corset blocks me to concentrate)]

Attachment: Patch

This patch makes:

ContentCache a base class and have only members which should be shared between processes.
ContentCacheInChild a derived class of ContentCache and have methods should be used by PuppetWidget.
ContentCacheInParent a derived class of ContentCache and have methods and member variables should be used by TabParent.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(no pain of the broken bone, but the corset blocks me to concentrate)]

Note that this patch does not change any logic. Just redesigned the class design.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8626361 [details] [diff] [review]
Patch

Review of attachment 8626361 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/ContentCache.cpp
@@ +466,5 @@
> +/*****************************************************************************
> + * mozilla::ContentCacheInParent
> + *****************************************************************************/
> +
> +ContentCacheInParent::ContentCacheInParent()

": ContentCache()" for initializing sContentCacheLog?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b4ada358d96

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b4ada358d96