Closed Bug 1177388 Opened 4 years ago Closed 4 years ago

[e10s] ContentCache should be separated as two clasesses

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(1 file)

I realized that ContentCache will be bigger than now for storing contents in parent.

So, for keeping the footprint in child process, we should create ContentCacheInParent class which is derived from ContentCache.
Attached patch PatchSplinter Review
This patch makes:

ContentCache a base class and have only members which should be shared between processes.
ContentCacheInChild a derived class of ContentCache and have methods should be used by PuppetWidget.
ContentCacheInParent a derived class of ContentCache and have methods and member variables should be used by TabParent.
Attachment #8626361 - Flags: review?(m_kato)
Note that this patch does not change any logic. Just redesigned the class design.
Comment on attachment 8626361 [details] [diff] [review]
Patch

Review of attachment 8626361 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/ContentCache.cpp
@@ +466,5 @@
> +/*****************************************************************************
> + * mozilla::ContentCacheInParent
> + *****************************************************************************/
> +
> +ContentCacheInParent::ContentCacheInParent()

": ContentCache()" for initializing sContentCacheLog?
Attachment #8626361 - Flags: review?(m_kato) → review+
https://hg.mozilla.org/mozilla-central/rev/7b4ada358d96
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.