1177403 - Unable to load http package resources with fetch() or xhr

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[[:fabrice] Fabrice Desré]

In a chrome js context, both:
fetch("http://foo.com/package.apk!//data.json") and using @mozilla.org/xmlextras/xmlhttprequest;1 fail to load the resource with a networking error.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Unable to load http package resources with fetch() or xhr

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8626409 [details] [diff] [review]
Unable to load http package resources with fetch() or xhr

Review of attachment 8626409 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/PackagedAppService.cpp
@@ +555,2 @@
>    nsCOMPtr<nsIChannel> channel;
>    rv = NS_NewChannel(

maybe use NS_NewChannel2() and pass aInfo? (if I'm not wrong)

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Honza Bambas (:mayhemer) from comment #2)
> Comment on attachment 8626409 [details] [diff] [review]
> Unable to load http package resources with fetch() or xhr
> 
> Review of attachment 8626409 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: netwerk/protocol/http/PackagedAppService.cpp
> @@ +555,2 @@
> >    nsCOMPtr<nsIChannel> channel;
> >    rv = NS_NewChannel(
> 
> maybe use NS_NewChannel2() and pass aInfo? (if I'm not wrong)

NewChannel2 doesn't take a LoadContextInfo, and I'd still need to pass the LOAD_ANONYMOUS flag when needed.

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to Valentin Gosu [:valentin] from comment #3)
> (In reply to Honza Bambas (:mayhemer) from comment #2)
> > Comment on attachment 8626409 [details] [diff] [review]
> > Unable to load http package resources with fetch() or xhr
> > 
> > Review of attachment 8626409 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: netwerk/protocol/http/PackagedAppService.cpp
> > @@ +555,2 @@
> > >    nsCOMPtr<nsIChannel> channel;
> > >    rv = NS_NewChannel(
> > 
> > maybe use NS_NewChannel2() and pass aInfo? (if I'm not wrong)
> 
> NewChannel2 doesn't take a LoadContextInfo, and I'd still need to pass the
> LOAD_ANONYMOUS flag when needed.

Ah!  This is nsILoadContextInfo (should rename this interface probably..) which is the necko/cache specific stuff.  Not nsILoadInfo.  I was wrong :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ee07ce81cf0

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6ee07ce81cf0