1177406 - Why is mIsMainThreadEvent set if an event has an owner?

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Seems kind of bogus ...

It also means that if you call BindToOwner on a DETH and then use DispatchTrustedEvent it will assert, because that event ends up with mIsMainThreadEvent set to true.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Because we certainly didn't use to have owner on workers.
And BindToOwner in DETH was about nsPIDOMWindow.

You're talking about BindToOwner+DispatchTrustedEvent on a worker?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yep.  nsm is doing that in notifications (well, he's skipping BindToOwner now ...)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

The idea was originally to skip extra NS_IsMainThread call when possible, 
but I guess we just should do this.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8626169 [details] [diff] [review]
patch

Review of attachment 8626169 [details] [diff] [review]:
-----------------------------------------------------------------

NS_IsMainThread should be fast inside libxul.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c071a0d3421

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c071a0d3421