1177417 - Lots of failures in security tests due to UI changes of the identity popup

Status: RESOLVED WORKSFORME

(Testing :: Firefox UI Tests, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As Tim told me a couple of days ago his work on bug 1170759 will certainly break tests. Given that the patch got landed earlier today, we have a lot of breakage in our Firefox UI tests with the Nightly build from today.

NoSuchElementException: Unable to locate element: identity-popup-icon

* test_toolbars_py TestIdentityPopup_test_popup_elements
* test_dv_certificate_py TestDVCertificate_test_dv_cert
* test_ev_certificate_py TestEVCertificate_test_ev_certificate

NoSuchElementException: Unable to locate element: identity-popup-connection-secure

* test_no_certificate_py TestNoCertificate_test_no_certificate
* test_mixed_content_page_py TestMixedContentPage_test_mixed_content

I'm going to fix that now.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: skip patch (github_pull_request)

I just landed the skip patch for now to turn our tests green. I should have a working patch by tomorrow. 

https://github.com/mozilla/firefox-ui-tests/commit/196330c3832864ac7afb5a1cec76d09733308e2f

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Without the UIBaseLib usage in our toolbar module, it will be harder to update everything. I hope to be able to land the patch on bug 1128968 still today or early tomorrow.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Tim, I have a problem with the expander button. I can call its click() method once so the security view gets opened. But issuing another click() doesn't hide the security view. Looks like no action takes place at all. Using a real mouse it indeed works. Is there anything I miss?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: fix v1 (github_pull_request.txt)

This PR implements new ui classes to cover the newly added subviews of the identity popup. It also restructures properties which have been attached to the wrong ui class.

The only thing which is still open to do is the closing of the security view. I will wait for a reply from Tim, and get another fix in a follow-up PR.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8626653 [details] [review]
fix v1 (github_pull_request.txt)

David gave the r+ via the PR.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

PR got merged as:
https://github.com/mozilla/firefox-ui-tests/commit/07277539b3ed0ad4f1db2a1a1d25b5c55d40086a

I will leave the bug open for the reply from Tim.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Henrik Skupin (:whimboo) from comment #3)
> Tim, I have a problem with the expander button. I can call its click()
> method once so the security view gets opened. But issuing another click()
> doesn't hide the security view. Looks like no action takes place at all.
> Using a real mouse it indeed works. Is there anything I miss?

The expander button expands the view, clicking it again doesn't close it though. You could just grab the <panelmultiview> and call .showMainView():

document.getElementById("identity-popup-multiView").showMainView();

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that we do not want to call any backend method but really restrict us to interact with ui elements, the above proposal will not work. So I chattet with Tim on IRC and a solution might be a click on clickCapturer:

http://mxr.mozilla.org/mozilla-central/source/browser/components/customizableui/content/panelUI.xml#24

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

At some point we got this fixed. All tests are running as expected those days.