Closed Bug 1177438 Opened 5 years ago Closed 5 years ago

[Control Center] Move "verified by" label up in the security subview

Categories

(Firefox :: General, defect, P1)

defect
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 41
Iteration:
41.3 - Jun 29
Tracking Status
firefox41 --- verified

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(2 files)

The "verified by" label is currently at the bottom, should be right under the gray separator though. We should at the same time adjust the color to a dark gray.
Flags: qe-verify+
Flags: firefox-backlog+
Attached image Design for subview
Whiteboard: [fxprivacy]
Priority: -- → P1
Not a big fan of the !important but 

#identity-popup-securityView > .identity-popup-text

seems to be more specific than just using the ID of the element :|
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8626395 - Flags: review?(gijskruitbosch+bugs)
Iteration: --- → 41.3 - Jun 29
Comment on attachment 8626395 [details] [diff] [review]
0001-Bug-1177438-Control-Center-Move-verified-by-label-up.patch

Review of attachment 8626395 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/controlcenter/panel.inc.css
@@ +191,5 @@
>    font-weight: 700;
>  }
>  
> +#identity-popup-content-verifier {
> +  color: rgb(99,99,99);

Hrm? The summary here says "move up", did the color have to change? Did you check the contrast here? :-)

@@ +201,1 @@
>  }

Could include the class and that would make it more specific, I think? Not sure.
Attachment #8626395 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs Kruitbosch from comment #3)
> > +#identity-popup-content-verifier {
> > +  color: rgb(99,99,99);
> 
> Hrm? The summary here says "move up", did the color have to change? Did you
> check the contrast here? :-)

First comment mentions the color ;) I'll check the contrast.

> @@ +201,1 @@
> Could include the class and that would make it more specific, I think? Not
> sure.

Good idea, will check!
Blocks: 1168421
No longer blocks: 1168421
https://hg.mozilla.org/mozilla-central/rev/27f5ace2fa5e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
QA Contact: catalin.varga
Verified as fixed using the following environment:

FF 41
Build Id:  20150716004006
OS: Win 7 x64, Ubuntu 14.04 x64, Mac Os X 10.9.5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.