1177441 - [Kb] Text missing in mobile site

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Content, task)

Description

[Orvi]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.130 Safari/537.36

Steps to reproduce:

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.152 Safari/537.36

Steps to reproduce:

Name 	Firefox
Version 	38.0.5
Build ID 	20150514163436
User Agent 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0

1. Go to here : https://support.mozilla.org/en-US/get-involved/kb?&mobile=0
2. Now scroll down and click "switch to mobile site"
3. Check the difference.


Actual results:

"1 ARTICLE CAN BE VIEWED BY 400 MILLION USERS AND TRANSLATED INTO 70+ LANGUAGES" is missing.


Expected results:

This text will be showed in the mobile site

Comment 1

[Orvi]

I would love to work on it.

Comment 2

[Tim [:pollti]]

Hi,
you can work on it, of course :) ! The related source code is https://github.com/mozilla/kitsune/blob/master/kitsune/landings/templates/landings/mobile/get-involved-kb.html and I think some of the other documents in https://github.com/mozilla/kitsune/tree/master/kitsune/landings/templates/landings/mobile are affected as well.
Let me know if you have any questions.
Thank you in advance!

Comment 3

[Tim [:pollti]]

Sorry, I didn't see that you have fixed get-involved-aoa.html already ;-). However, https://support.mozilla.org/en-US/get-involved/questions and https://support.mozilla.org/en-US/get-involved/l10n are affcted, too.

Comment 4

[Orvi]

wow Thanks for notice it . By the way, can I fix those texts too in my patch? or Do I need to fill same bug again and again ?

Comment 5

[Tim [:pollti]]

You can fix them in one patch, because they are closely connected.

Comment 6

[Orvi]

Attachment: Fix everything

Okay I add a patch for this bug. please  check it and let me know everything is okay or not.

Comment 7

[Tim [:pollti]]

Comment on attachment 8626381 [details] [review]
Fix everything

It looks good in my local kitsune :)
Howerver, I think it would be good if you could change
>"{{ _('solving 1 issue helps up to 1,000 Users a day') }}"
to
>"{{ _('Solving 1 issue helps up to 1,000 users a day') }}"
(https://github.com/mozilla/kitsune/pull/2583/files#diff-a4c050c425720b4b470b8dcca45d2f1eR27 ➔ uppercase S in "Solving" and lowercase u in "users")
This makes no difference at the moment, but it could make a difference if the font is changed in the future.

You can undo your changes by using
> git reset --hard 5a969d0
> git push --force
and then remake the changes including the new upper-/lowercase.

Thank you very much :)

Comment 8

[Orvi]

okay, I update the patch. Can we merge it now ? or any more further change ?

Comment 9

[Tim [:pollti]]

Thank you very much for the patch :) 

Comment 10

[Tim [:pollti]]

We have to wait for an admin to review and merge it.

Comment 11

[Michael Cooper [:mythmon]]

PR: https://github.com/mozilla/kitsune/pull/2583
Merged in: https://github.com/mozilla/kitsune/commit/04028d2b7afe7a0100b6269ba794e678d6804ac0
I deployed this to prod.