Closed
Bug 1177461
Opened 9 years ago
Closed 9 years ago
[EME] EME plugin voucher still disappearing
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.96 KB,
patch
|
eflores
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
It seems that despite of bug 1173144, we still have the Adobe EME plugin voucher is appearing to be present on disk at startup, but is disappearing by the time we get to run the EME plugin. So we should check that the EME plugin voucher is still on disk when we try to startup the EME plugin.
Assignee | ||
Comment 1•9 years ago
|
||
Check that the Adobe EME plugin voucher is on disk before we advertise to content that it works.
Attachment #8626227 -
Flags: review?(edwin)
Comment on attachment 8626227 [details] [diff] [review] Patch: Check that the plugin voucher is on disk before advertising Adobe EME Review of attachment 8626227 [details] [diff] [review]: ----------------------------------------------------------------- ...ugh...
Attachment #8626227 -
Flags: review?(edwin) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/baf797bf2912
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8626227 [details] [diff] [review] Patch: Check that the plugin voucher is on disk before advertising Adobe EME Approval Request Comment [Feature/regressing bug #]: EME [User impact if declined]: Without this patch, Adobe EME will fail on some users' systems. On some users' systems, a file that accompanies the EME Plugin, the "plugin voucher file", is being deleted at runtime by some unknown process, and Adobe EME is failing to startup. With this patch, we make Gecko check that the plugin voucher is present on disk before advertising to javascript that EME will work. [Describe test coverage new/current, TreeHerder]: Lots of EME mochitests. [Risks and why]: Low; we already check for some other files on startup, so this is just taking the same code path again. [String/UUID change made/needed]: None.
Flags: needinfo?(cpearce)
Attachment #8626227 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•9 years ago
|
status-firefox38:
--- → wontfix
status-firefox38.0.5:
--- → wontfix
status-firefox39:
--- → affected
status-firefox40:
--- → affected
Flags: needinfo?(cpearce)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(cpearce)
Assignee | ||
Comment 6•9 years ago
|
||
[Tracking Requested - why for this release]: This is our largest source of EME errors that we can do something about; we need to get this into Beta ASAP.
tracking-firefox40:
--- → ?
Assignee | ||
Comment 7•9 years ago
|
||
Try beta push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=524d378cca90
Adding a qe-verify flag to ensure we test the fix. Chris, have we verified that the fix works?
Flags: qe-verify+
Comment on attachment 8626227 [details] [diff] [review] Patch: Check that the plugin voucher is on disk before advertising Adobe EME Approving for Beta and the try push was clean according to Chris.
Attachment #8626227 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Adding a tracking flag for FF40.
Assignee | ||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/b1b9503edc7c
Flags: needinfo?(cpearce)
Assignee | ||
Comment 12•9 years ago
|
||
While verifying this for beta I realised I missed a case; I'll need another patch...
Comment 13•9 years ago
|
||
(In reply to Chris Pearce (:cpearce) from comment #12) > While verifying this for beta I realised I missed a case; I'll need another > patch... Fodder for a follow-up bug for better tracking? Otherwise, please reopen this bug and re-set the status flags to affected.
Comment 14•9 years ago
|
||
Reproduced with Nightly 2015-06-19, under Windows 7 64-bit: after deleting the voucher file, "1436541168530 Toolkit.GMP ERROR GMPInstallManager.simpleCheckAndInstall Could not check for addons: {"target":},"status":0,"message":"request.status: 0 (timeout)"}" is displayed in Browser Console and I couldn't enable EME. Verified fixed with Firefox 40 beta 3 (Build ID: 20150709163524), under Windows 7 64-bit and Windows 10 32-bit, including with str from bug 1180610 comment 17.
You need to log in
before you can comment on or make changes to this bug.
Description
•