[EME] EME plugin voucher still disappearing

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks 1 bug)

unspecified
mozilla41
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox38 wontfix, firefox38.0.5 wontfix, firefox39 wontfix, firefox40+ verified, firefox41 fixed)

Details

Attachments

(1 attachment)

It seems that despite of bug 1173144, we still have the Adobe EME plugin voucher is appearing to be present on disk at startup, but is disappearing by the time we get to run the EME plugin.

So we should check that the EME plugin voucher is still on disk when we try to startup the EME plugin.
Check that the Adobe EME plugin voucher is on disk before we advertise to content that it works.
Attachment #8626227 - Flags: review?(edwin)
Comment on attachment 8626227 [details] [diff] [review]
Patch: Check that the plugin voucher is on disk before advertising Adobe EME

Review of attachment 8626227 [details] [diff] [review]:
-----------------------------------------------------------------

...ugh...
Attachment #8626227 - Flags: review?(edwin) → review+
https://hg.mozilla.org/mozilla-central/rev/baf797bf2912
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8626227 [details] [diff] [review]
Patch: Check that the plugin voucher is on disk before advertising Adobe EME

Approval Request Comment
[Feature/regressing bug #]: EME

[User impact if declined]:

Without this patch, Adobe EME will fail on some users' systems.

On some users' systems, a file that accompanies the EME Plugin, the "plugin voucher file", is being deleted at runtime by some unknown process, and Adobe EME is failing to startup. With this patch, we make Gecko check that the plugin voucher is present on disk before advertising to javascript that EME will work.

[Describe test coverage new/current, TreeHerder]: Lots of EME mochitests.

[Risks and why]: Low; we already check for some other files on startup, so this is just taking the same code path again.

[String/UUID change made/needed]: None.
Flags: needinfo?(cpearce)
Attachment #8626227 - Flags: approval-mozilla-beta?
Flags: needinfo?(cpearce)
Flags: needinfo?(cpearce)
[Tracking Requested - why for this release]: This is our largest source of EME errors that we can do something about; we need to get this into Beta ASAP.
Adding a qe-verify flag to ensure we test the fix. Chris, have we verified that the fix works?
Flags: qe-verify+
Comment on attachment 8626227 [details] [diff] [review]
Patch: Check that the plugin voucher is on disk before advertising Adobe EME

Approving for Beta and the try push was clean according to Chris.
Attachment #8626227 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Adding a tracking flag for FF40.
While verifying this for beta I realised I missed a case; I'll need another patch...
(In reply to Chris Pearce (:cpearce) from comment #12)
> While verifying this for beta I realised I missed a case; I'll need another
> patch...

Fodder for a follow-up bug for better tracking? Otherwise, please reopen this bug and re-set the status flags to affected.
Reproduced with Nightly 2015-06-19, under Windows 7 64-bit: after deleting the voucher file, "1436541168530	Toolkit.GMP	ERROR	GMPInstallManager.simpleCheckAndInstall Could not check for addons: {"target":},"status":0,"message":"request.status: 0 (timeout)"}" is displayed in Browser Console and I couldn't enable EME. 
Verified fixed with Firefox 40 beta 3 (Build ID: 20150709163524), under Windows 7 64-bit and Windows 10 32-bit, including with str from bug 1180610 comment 17.
You need to log in before you can comment on or make changes to this bug.