Closed
Bug 1177476
Opened 9 years ago
Closed 9 years ago
Fix require_conditions regression from bug 1176620
Categories
(Firefox Build System :: Mach Core, enhancement)
Firefox Build System
Mach Core
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
Bug 1176620 changed the default conditions from None to [] which breaks require_conditions that have a 'conditions is None' check. This means all Firefox-only mach commands show up in |mach help| for B2G even though they don't work. The presence of conditions is a pretty stupid check to be using, maybe I should just add a !B2G condition to every command that doesn't work there. But this bug should be fixed either way.
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1177476 - Fix require_conditions regression in mach, r?gps This is a regression from bug 1176620 that results in all Firefox mach commands showing up in the help for B2G, even though they don't work there.
Attachment #8626250 -
Flags: review?(gps)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8626250 [details] MozReview Request: Bug 1177476 - Fix require_conditions regression in mach, r?gps https://reviewboard.mozilla.org/r/12045/#review10475 Good catch.
Attachment #8626250 -
Flags: review?(gps) → review+
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/41c7369a3090
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•