1177558 - Allocations tree (and chart) is always empty

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Make sure you have "record allocations" checked. Restart firefox after checking.

STR:

* Open perf tool
* Go to https://swannodette.github.io/todomvc/labs/architecture-examples/om/
* Start recording
* Click "benchmark 1"
* Stop recording
* Go to allocations tree

ER:

Allocations appear ("benchmark 1" definitely allocates)

AR:

Nothing there. Nor in allocation charts.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

This is from trying to offset the docshell timestamps by a Date.now() in the memory actor, leaving us with wildly negative numbers. Saving this for when the performance actor is a real actor, to make things way easier.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1177558-fix-allocs.patch

Moved logic that fixed this from bug 1172180 to here. The docshell timing is weird how we do it, but that's how we do it everywhere else, and if it's ugly, it's because we should clean it up everywhere

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b40c4c7bbbf2

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8643382 [details] [diff] [review]
1177558-fix-allocs.patch

Review of attachment 8643382 [details] [diff] [review]:
-----------------------------------------------------------------

Played with it and everything works again! Great!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7c556da6de98

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7c556da6de98