Closed Bug 1177615 Opened 5 years ago Closed 5 years ago

Remove FLAG_DECODE_STARTED and related code from ImageLib

Categories

(Core :: ImageLib, defect)

Product:
Core
Component:
ImageLib
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

Rip everything related to FLAG_DECODE_STARTED out of ImageLib
18.84 KB, patch
tnikkel
: review+
Details | Diff | Splinter Review 
Bug 1177604 removes the last use of FLAG_DECODE_STARTED outside of ImageLib.

The only remaining usage is inside of ImageLib - imgRequestProxy resets an image's cache entry when an image starts decoding, to prevent multipart image's cache entry size from growing without bound. We can handle that directly in imgRequest, though, so this usage isn't necessary either.

In this bug, I'll handle resetting the cache entry size in imgRequest, and remove every other piece of code that only exists to support FLAG_DECODE_STARTED. It's a surprising amount of code!
Here's the patch. Tons of code deleted.
Attachment #8626410 - Flags: review?(tnikkel)
Try looks green.
Attachment #8626410 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/20748e1e2276
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.