Closed
Bug 1177651
Opened 9 years ago
Closed 9 years ago
test_moz_mouse_pixel_scroll_event.html fails with APZ enabled
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(3 files, 4 obsolete files)
15.90 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
1.12 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
2.42 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
test_moz_mouse_pixel_scroll_event.html (in m-e10s-1) fails with APZ enabled on Linux. I was able to reproduce locally and debug using rr. The first problem turned out to be that the MozMousePixelScroll event that the test waits for becomes asynchronous with APZ enabled, and so the test needs to be updated to yield after synthesizing the wheel event.
Even with that fixed though there appears to be a race somewhere (which I *can't* reproduce locally) that causes some of the test assertions to fail on try.
Assignee | ||
Comment 1•9 years ago
|
||
This fixes the issue I identified above, but the test isn't fully green yet.
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8626447 -
Attachment is obsolete: true
Assignee | ||
Comment 3•9 years ago
|
||
Doing a preventDefault on a MozMousePixelScroll event is supposed to cancel the scrolling, so APZ needs to wait for the response, and therefore layout needs to put areas covered by these events in the dispatch-to-content region.
Assignee | ||
Comment 4•9 years ago
|
||
We may or may not need this also. It was one of my earlier attempts at fixing this problem (before I figured out part 2 and the dependent bug).
I did a try push without this patch at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b0b2ea9d345, if that's green then we shouldn't need this.
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d2c22105132 is better, with less logging.
Assignee | ||
Comment 6•9 years ago
|
||
The test is still failing but with a lower frequency it appears. I did another push with the part 3 patch at https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6f1df7f8cc5, but I also discovered another potential problem - the AddEventListener call in the test doesn't trigger a new layers transaction, so the event regions on the APZ side are stale. We might need to trigger a layout flush of some sort if an APZ-aware listener is added or removed.
Assignee | ||
Updated•9 years ago
|
Attachment #8626960 -
Attachment description: Part 3 WIP → Part 3 - Extend content response timeout to deal with the test running slowly in automation
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8626958 -
Attachment is obsolete: true
Attachment #8627257 -
Flags: review?(dvander)
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8626959 -
Attachment is obsolete: true
Attachment #8627258 -
Flags: review?(dvander)
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8626960 -
Attachment is obsolete: true
Attachment #8627260 -
Flags: review?(dvander)
Attachment #8627257 -
Flags: review?(dvander) → review+
Attachment #8627258 -
Flags: review?(dvander) → review+
Attachment #8627260 -
Flags: review?(dvander) → review+
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #6)
> The test is still failing but with a lower frequency it appears. I did
> another push with the part 3 patch at
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6f1df7f8cc5, but I
> also discovered another potential problem - the AddEventListener call in the
> test doesn't trigger a new layers transaction, so the event regions on the
> APZ side are stale. We might need to trigger a layout flush of some sort if
> an APZ-aware listener is added or removed.
Yuck. That could explain why other tests are intermittently failing.
Comment 11•9 years ago
|
||
Assignee | ||
Comment 12•9 years ago
|
||
(In reply to David Anderson [:dvander] from comment #10)
> Yuck. That could explain why other tests are intermittently failing.
Possibly, yeah. I filed bug 1178743 for it.
https://hg.mozilla.org/mozilla-central/rev/bf2dc08fe83a
https://hg.mozilla.org/mozilla-central/rev/55a2ebc33984
https://hg.mozilla.org/mozilla-central/rev/e8ea2a9493da
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•