117766 - With a non-NULL target argument, NPN_GetURLNotify and NPN_PostURLNotify do not cause NPP_Notify to be called

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect, P2)

Description

[av (gone)]

If you look at ns4xPlugin.cpp _geturlnotify method (as of today it is here: 
http://lxr.mozilla.org/seamonkey/source/modules/plugin/base/src/ns4xPlugin.cpp#7
00 ), you will notice that we create a stream only for null-targets:

  if(target == nsnull)
    ((ns4xPluginInstance*)inst)->NewNotifyStream(&listener, notifyData);

This is probably not correct. The Tester plugin shows a difference between 
Mozilla and NS4.x where the notification comes regardless of the target used.

Comment 1

[Peter Lubczynski]

nominating nsbeta1, mozilla.10

Comment 2

[Arun Ranganathan]

Marking nsbeta1- per ADT.

Comment 3

[R.K.Aa.]

fixed in bug 127259?

Comment 4

[serge (gone)]

nope, it does not.

Comment 5

[Peter Lubczynski]

I think this may be a bit more difficult to fix.

Currently, non-null targeted requests get funnled through nsILinkHandler:
http://lxr.mozilla.org/mozilla/source/layout/html/base/src/nsObjectFrame.cpp#2252

The problem is that this opens the stream asynchronsly in the webshell and
plugin code has know way of knowing when to call URLNotify.

One possibility is to use the newly added |OnLinkClickSync| on nsILinkHandler
which works synchronsly PLUS returns a nsIRequest and nsIDocShell. An
nsIWebProgressListener can then be attached to the docshell and a notification
fired when loading is done.

Comment 6

[rubydoo123]

setting to 1.1

Comment 7

[rubydoo123]

*** Bug 56311 has been marked as a duplicate of this bug. ***

Comment 8

[serge (gone)]

taking this bug

Comment 9

[serge (gone)]

Attachment: patch v1

this patch seams to work, I need to find out the right header file for
declaration of struct _NPN_NotifyRequire

Comment 10

[serge (gone)]

actually it seams to me it would be much easy to put that struct into local *.h
file after landing the patch for bug 136927

Comment 11

[serge (gone)]

Attachment: patch v1.2

set flag to avoid conflict when plugin issues  several GetURLNotify with the
same url & target (not final yet)

Comment 12

[rubydoo123]

moving to 1.4beta, plug-in branch work

Comment 13

[Peter Lubczynski]

-->peterl

Comment 14

[Peter Lubczynski]

per topembed+ triage: P2

Comment 15

[Benjamin Smedberg]

At this point, we do not intend to fix this behavior.