Closed
Bug 1177662
Opened 9 years ago
Closed 9 years ago
[Contacts][NGA] Move header methods to a new separate js class from contacts.js
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S2 (10Jul)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: mancas, Assigned: mancas)
References
Details
(Whiteboard: [NG Gaia Contacts][patch])
Attachments
(1 file)
We have a lot of common methods that update the header state within the application so we should move those methods to a new separate js file, in order to reduce the dependencies with contacts.js
|
||
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8626470 -
Flags: review?(borja.bugzilla)
|
|
||
Updated•9 years ago
|
Target Milestone: --- → FxOS-S1 (26Jun)
|
|
||
Updated•9 years ago
|
Target Milestone: FxOS-S1 (26Jun) → FxOS-S2 (10Jul)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8626470 [details] [review] Move header methods to a new js file Some comments in Github. Let me know when ready and I'll review this code again!
Attachment #8626470 -
Flags: review?(borja.bugzilla)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8626470 [details] [review] Move header methods to a new js file Patch ready to be reviewed again! Thanks!!!
Attachment #8626470 -
Flags: review?(borja.bugzilla)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8626470 [details] [review] Move header methods to a new js file Some comments in Github, but not blocking. Fix them and ready to merge! Great job Manu!
Attachment #8626470 -
Flags: review?(borja.bugzilla) → review+
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Updated•9 years ago
|
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•