1177719 - TypeError: ltnImipBar.itipItem is null (when using Thunderbird Conversations)

Status: RESOLVED INVALID

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Ben Lerner]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150525141253

Steps to reproduce:

I have a GData calendar configured, and I have it selected in the list of calendars in the Calendar tab so that any new events get created in that calendar by default.  I also have TBConversations enabled, which might be relevant.

I received a meeting invitation from someone (in an IMAP email account, if that matters).  The lightning invitation bar appears in the message, and I click on Accept.


Actual results:

Nothing visible.  The error console contains:

Timestamp: 6/26/2015 10:06:13 AM
Error: TypeError: ltnImipBar.itipItem is null
Source File: chrome://lightning/content/imip-bar.js
Line: 276


Expected results:

The event should've been accepted, and not thrown a JS error.

I tried again, by opening the email in the classic viewer instead of TBConv's view.  Again the invitation bar appears, but this time it's a bit different looking.  When I click on Accept now, it opens a dialog asking which calendar to import into -- but doesn't show all of my calendars, for some reason.  It only shows one calendar per email account, as far as I can tell.  When I selected one of those calendars, though, the event imported successfully.

Apologies if this is the wrong component to file the bug against -- I'm reporting this bug here based on the chrome://lightning/content/imip-bar.js source file, even though it appears to be somewhat related to TBConv.  I also don't know if the not-showing-all-calendars behavior is a separate bug or a related one.

Comment 1

[Stefan Sitter [:ssitter]]

What version of Thunderbird Conversations do you use? The extension provides its own invitation bar implementation as you already noticed. Maybe it has to be updated to be compatible with Lightning 4.0 or maybe it triggers a bug in Lightning.

Maybe you can open your profile folder, search for imip-bar.js, open it for editing, go to line 276 and enter the following line above it:

    if (!ltnImipBar.itipItem) { cal.ERROR("ltnImipBar.itipItem is null"); }

This should give a more detailed message in console including the call stack.

Comment 2

[Ben Lerner]

Sorry, should've included all the relevant versions: TBConv 2.9.1, Lightning 4.0.0.1, TB 38.0.1, and Provider for Google Calendar 1.0.4.  I'll try adding that debugging line, and ask the invitation-sender to send me another invite to test out...

Comment 3

[[:MakeMyDay]]

So, you're already on the latest version of TC.

> I tried again, by opening the email in the classic viewer instead of
> TBConv's view.  Again the invitation bar appears, but this time it's a bit
> different looking.  When I click on Accept now, it opens a dialog asking
> which calendar to import into -- but doesn't show all of my calendars, for
> some reason.  It only shows one calendar per email account, as far as I can
> tell.  When I selected one of those calendars, though, the event imported
> successfully.

The limitation of calendars in the prompt is intended. You get prompted only those calendars, which are capable for email scheduling, which means they are used to support that in general, need to be writable, have an organizer configured in calendar properties. While the first is something based on the calendar type, the latter ones depend on user settings, so just check the same in the calendar properties of the calendars you're missing. Also, if you have already different calendar organizers confirgured, and more than one is in the attendee list of the invitation, only those calendars get prompted.

If you think there's something wrong, please file a separate bug for that.
 
> Apologies if this is the wrong component to file the bug against -- I'm
> reporting this bug here based on the chrome://lightning/content/imip-bar.js
> source file, even though it appears to be somewhat related to TBConv.  I
> also don't know if the not-showing-all-calendars behavior is a separate bug
> or a related one.

Based on your test with/without TC, this needs a fix at TC. So, please also check [1]. There seem to be related issues filed already, but without any progress. If you add a comment or a new issue there, consider to add a back reference to this bug report.

I'm not familiar with TC, but there w.ltnImipBar.itipItem gets initialized at [2], but eventually there is a race condition with Lightning code, as we reset the bar at places [3], which also resets ltnImipBar.itipItem to null - or there is no appropriate reset of the bar when switching between messages using TC view.

Protz, if there's anything to do at Lightning end, please leave a comment here.

[1] https://github.com/protz/GMail-Conversation-View/issues
[2] https://github.com/protz/GMail-Conversation-View/blob/master/modules/plugins/lightning.js#L73
[3] http://mxr.mozilla.org/comm-central/search?string=resetBar&find=%2Fcalendar%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Comment 4

[Ben Lerner]

How does one check the organizer in the calendar properties?  I have several calendars (all Google calendars, now updated with googleapi: locations instead of the older ics locations) associated with several accounts, but only one calendar in each account appears.  When I look at calendar properties for those calendars that do appear, I see an E-Mail field in the properties window, whereas that field is missing entirely for the other ones...  I think the other ones are "secondary calendars" according to Google nomenclature -- but according to bug #684482, which is fixed, I thought this limitation for Lightning/GData had been resolved.

Comment 5

[[:MakeMyDay]]

Please let's keep this bug for the TC issue only as mentioned before to have one bug per issue.

The prompt thing is completely unrelated. If that is an issue for you please open a bug in calendar's gdata component, allthough iirc only the primary calendar of a Google account supports scheduling.

Comment 6

[Jonathan Protzenko [:protz]]

Thanks MakeMyDay for the detailed comments / suggested fix. I'm closing this issue on the basis that it's already tracked at https://github.com/protz/GMail-Conversation-View/issues/961 which is the right bugtracker for Thunderbird Conversations issues; I've cross-referenced both issues to make sure that the pointer to your suggested fix isn't lost.

Your suggested fix is probably right -- it's just that I'm not using Lightning myself, and I'm already doing a lot of Javascript debugging during the week, so I tend to favor doing other stuff on weekends, quite regrettably for the Conversations addon :). If you feel like giving this a quick try / fixing it, I'd be more than happy to integrate a pull request.

Thanks,

Jonathan