Permalinks broken for Rust tree

RESOLVED FIXED

Status

Webtools
DXR
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: new_one, Assigned: new_one)

Tracking

Trunk

Firefox Tracking Flags

(firefox42 affected)

Details

(Assignee)

Description

3 years ago
The permalink feature is broken on the rust tree and 404's for any files not directly in the root directory. For example, https://dxr.allizom.org/rust/rev/6065bed37be55427ed0ac888b863a85696b28f9b/mk/llvm.mk.
In the root directory, permalinks do work: https://dxr.allizom.org/rust/rev/6065bed37be55427ed0ac888b863a85696b28f9b/AUTHORS.txt

This could be a problem with Git repository handling, or one with this Rust index specifically.
rebuilt rust, finally, using nrc's dxr.config, and permalinks are still broken.

abort: no repository found in '/data/dxr_data/rust/src/libcollections' (.hg not found)!
fatal: Path 'src/libcollections/slice.rs' exists, but not 'slice.rs'.
Did you mean '21dd4e2a0627daa2f9023084e253e75ccfaa5137:src/libcollections/slice.rs' aka '21dd4e2a0627daa2f9023084e253e75ccfaa5137:./slice.rs'?

dxr1.stage.webapp.scl3# pwd
/data/stage/src/rust
dxr1.stage.webapp.scl3# git rev-parse HEAD
21dd4e2a0627daa2f9023084e253e75ccfaa5137
(Assignee)

Updated

3 years ago
Assignee: nobody → peter.elmers

Comment 2

3 years ago
Commit pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/eb45c23236b3099ca965fe30cce16e2eee41aa7d
Fix bug 1177761, non-root directory git permalinks.

git’s show command requires a "./" prepended to the file name to make
it relative to cwd, rather than the git root.
Add a test to make sure this does not regress.

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 3

2 years ago
Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/eb45c23236b3099ca965fe30cce16e2eee41aa7d
Fix bug 1177761, non-root directory git permalinks.
You need to log in before you can comment on or make changes to this bug.