1177782 - Take a screenshot after all mochitest failures

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

In our intermittent orange discussion today, the idea of taking screenshots after all test failures was raised. We currently only take them after a timeout, but state can be helpful for regular failures as well.

Comment 2

[Martijn Wargers (dead)]

I guess bug 711124 is about the regular failures.

Comment 4

[(not currently active) Ted Mielczarek]

I think we wired the plumbing up for this ages ago, shouldn't be hard to turn on.

Comment 5

[Andrew Halberstadt [:ahal]]

Yeah, we have --screenshot-on-fail.. I haven't used it before, so not sure how well it works, but might just be a matter of adding it to the in-tree configs.

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1177782 - Enable --screenshot-on-fail for mochitests

Bug 1177782 - Enable --screenshot-on-fail for mochitests

Comment 7

[Andrew Halberstadt [:ahal]]

Above might be all we need, I'd like to see it working across all the platforms first.. here's a try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb42ee341afc

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8626630 [details]
MozReview Request: Bug 1177782 - Enable --screenshot-on-fail for mochitests

Bug 1177782 - Enable --screenshot-on-fail for mochitests

Comment 9

[Andrew Halberstadt [:ahal]]

The try run looks good. I'm going to be PTO all next week, so assuming r+ if someone could land or set checkin-needed that would be appreciated. Otherwise I'll do it when I get back.

Comment 10

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8626630 [details]
MozReview Request: Bug 1177782 - Enable --screenshot-on-fail for mochitests

https://reviewboard.mozilla.org/r/12109/#review10691

Looks good.  This is a no-op for Android emulator tests, looking at the try run, and probably for B2G emulator tests as well, but we can address those with follow-ups.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec2988092893

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec2988092893