Enable the bundleclone extension by default

RESOLVED FIXED

Status

mozilla.org
MozillaBuild
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

We ship a Mercurial version that supports bundleclone. We should ship with it enabled by default.
Assignee: nobody → ryanvm
Blocks: 1201520
Depends on: 1199356
Created attachment 8663635 [details] [diff] [review]
enable bundleclone by default

For your rubberstamping pleasure.
Attachment #8663635 - Flags: review?(gps)
Created attachment 8663912 [details] [diff] [review]
enable bundleclone by default

This patch even works.
Attachment #8663635 - Attachment is obsolete: true
Attachment #8663635 - Flags: review?(gps)
Attachment #8663912 - Flags: review?(gps)

Comment 3

2 years ago
Comment on attachment 8663912 [details] [diff] [review]
enable bundleclone by default

Review of attachment 8663912 [details] [diff] [review]:
-----------------------------------------------------------------

I plan on adding the bundleclone functionality to core Mercurial, hopefully in version 3.6. In theory, the utility of this change will be temporary and only necessary until the first MozillaBuild release after Nov 1.

Still, a few weeks is a few weeks. Plus there's no guarantee I'll make the 3.6 deadline.

LGTM.
Attachment #8663912 - Flags: review?(gps) → review+
And realistically, we probably won't update Mercurial again until at least 3.6.1, so we're talking mid-November at best until we ship a version with it built-in.

gkw and I did run into one interesting bug while testing this - it works fine for |hg clone|, but doesn't work for client.py checkouts unless enabled at the user level (i.e. in ~/mercurial.ini). Not sure why, but edge-case enough that I'm not going to let it block this from landing.

http://hg.mozilla.org/mozilla-build/rev/24441a7c491c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Depends on: 1209289
You need to log in before you can comment on or make changes to this bug.