1177789 - Make luciddream mozharness upload log files to blobber

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

The lucciddream job isn't uploading gecko log files, which makes it hard to debug failures, like the one in bug 1161702.  We should fix this.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Make lucciddream upload log files to blobber,

Comment 2

[Jonathan Griffin (:jgriffin)]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b29034c3ae97

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8626619 [details] [diff] [review]
Make lucciddream upload log files to blobber,

Review of attachment 8626619 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm! r+ with comment addressed.

::: scripts/luciddream_unittest.py
@@ +278,5 @@
> +        if not os.path.exists(dirs['abs_blob_upload_dir']):
> +            self.mkdir_p(dirs['abs_blob_upload_dir'])
> +        for filename in os.listdir(dirs['abs_work_dir']):
> +            if filename.endswith('.log'):
> +                shutil.copy(os.path.join(dirs['abs_work_dir'], filename),

Should use self.copyfile here (or self.move)

Comment 4

[Jonathan Griffin (:jgriffin)]

Nit fixed, http://hg.mozilla.org/build/mozharness/rev/99bf0c98665d

Comment 5

[Jonathan Griffin (:jgriffin)]

testing a mozharness bump: https://treeherder.mozilla.org/#/jobs?repo=try&revision=73123b66b215

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35e4be55eab8

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/35e4be55eab8