Closed Bug 1177789 Opened 6 years ago Closed 6 years ago

Make luciddream mozharness upload log files to blobber

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file)

The lucciddream job isn't uploading gecko log files, which makes it hard to debug failures, like the one in bug 1161702.  We should fix this.
Comment on attachment 8626619 [details] [diff] [review]
Make lucciddream upload log files to blobber,

Review of attachment 8626619 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm! r+ with comment addressed.

::: scripts/luciddream_unittest.py
@@ +278,5 @@
> +        if not os.path.exists(dirs['abs_blob_upload_dir']):
> +            self.mkdir_p(dirs['abs_blob_upload_dir'])
> +        for filename in os.listdir(dirs['abs_work_dir']):
> +            if filename.endswith('.log'):
> +                shutil.copy(os.path.join(dirs['abs_work_dir'], filename),

Should use self.copyfile here (or self.move)
Attachment #8626619 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/35e4be55eab8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.