Closed Bug 1177801 Opened 5 years ago Closed 5 years ago

Remove NewObjectWithProto

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(1 file)

We already have NewObjectWithGivenProto, so you should always get the ClassProto instead of calling out from NewObjectWithClassProtoCommon when somebody passes a proto.
I have the feeling some of the code we use for TypedObjects is too complicated. I replaced cases where we had a non-null proto with NewObjectWithGivenProto, and the other cases with NewBuiltinClassInstance.
Attachment #8627942 - Flags: review?(bhackett1024)
Attachment #8627942 - Flags: review?(bhackett1024) → review+
Keywords: leave-open
Summary: Remove proto argument from NewObjectWithClassProto → Remove NewObjectWithProto
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: leave-open
Resolution: --- → FIXED
Blocks: 1185390
You need to log in before you can comment on or make changes to this bug.