1177848 - Add telemetry for successful and unsuccessful connections to ipv4 and ipv6 addresses

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect)

Description

[Dragana Damjanovic [:dragana]]

Count successful and unsuccessful connections to ipv4 and ipv6 addresses.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: ipv6_telemetry.patch

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8626684 [details] [diff] [review]
ipv6_telemetry.patch

Review of attachment 8626684 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Histograms.json
@@ +2485,5 @@
>      "high": "60000",
>      "n_buckets": 1000,
>      "description": "Time spend blocked on poll (ms)."
>    },
> +  "CONNECTED_TO_IPV4_ADDRESS_COUNT" : {

can we make this a single quad state instead? It will be easier to compare the changes over time.

Comment 3

[Patrick McManus [:mcmanus]]

oh, and its likely we'll be able to uplift this to 41-aurora as its just telemetry and that will give us a control for the change to 42.

Comment 4

[Dragana Damjanovic [:dragana]]

Attachment: ipv6_telemetry.patch

Comment 5

[Patrick McManus [:mcmanus]]

Comment on attachment 8628293 [details] [diff] [review]
ipv6_telemetry.patch

Review of attachment 8628293 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: toolkit/components/telemetry/Histograms.json
@@ +2489,5 @@
> +  "IPV4_AND_IPV6_ADDRESS_CONNECTIVITY": {
> +    "expires_in_version": "never",
> +    "kind": "enumerated",
> +    "n_values": 4,
> +    "description": "Count the number of successful and unsuccessful connections to a ipv4 and ipv6 address."

you can note the enumerated values right in the description. I've found that helpful.

Comment 6

[Dragana Damjanovic [:dragana]]

Attachment: ipv6_telemetry.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3407e9994698

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bafb4cd0e905

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bafb4cd0e905